Re: [Buildroot] [PATCH 1/1] package/gettext-gnu: bump to version 0.22

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: Vadim Kochan <vadim4j@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/gettext-gnu: bump to version 0.22
Date: Sat, 19 Aug 2023 20:44:03 +0200	[thread overview]
Message-ID: <20230819184403.GD1778688@scaer> (raw)
In-Reply-To: <20230819145925.324644-1-bernd@kuhls.net>

Bernd, All,

On 2023-08-19 16:59 +0200, Bernd Kuhls spake thusly:
> Release notes:
> https://lists.gnu.org/archive/html/info-gnu/2020-07/msg00009.html
> https://lists.gnu.org/archive/html/info-gnu/2023-06/msg00003.html
> 
> Removed patch 0001, the patched file is not present in this release.
> Removed patch 0002 which was applied upstream.
> 
> Added comment to gettext-tiny.mk about version bumps.
> 
> Since upstream commit
> https://github.com/autotools-mirror/gettext/commit/785a89e5df994c2b242f082d60de89e2d520aa4a
> gettext-runtime is a build-dependency for gettext-tools so we are
> building the complete package for the host from now on.

So, the reason for the partial build was to gain a bit of time. So I did
a few very simplest tests:

    $ make distclean; make defconfig
    $ time make host-gettext-gnu-depends          Before    After
                                                  59s       24s
    $ time make host-gettext-gnu                  2min 22s  3min 3s
                                           Total: 3min 21s  3min 27s

We loose about 6s.

That is a bit skewed, in fact, because the dependencies of
host-gettext-gnu which was autoreconfed, are dependencies of other
packages, so we don't really gain 35s there... Still, the delta in
build time is not worth the efforts in maintenance.

> Doing so we can drop package host-libtextstyle and a _POST_INSTALL_HOOK.
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
>  .checkpackageignore                           |   2 -
>  .../0001-error_print_progname.patch           |  20 ---
>  ...-buld-gettext-tools-seperately-part1.patch | 142 ------------------
>  package/gettext-gnu/gettext-gnu.hash          |   7 +-
>  package/gettext-gnu/gettext-gnu.mk            |  24 +--
>  package/gettext-tiny/gettext-tiny.hash        |   6 +-
>  package/gettext-tiny/gettext-tiny.mk          |   3 +-
>  package/libtextstyle/libtextstyle.hash        |   6 -
>  package/libtextstyle/libtextstyle.mk          |  24 ---
>  9 files changed, 16 insertions(+), 218 deletions(-)
>  delete mode 100644 package/gettext-gnu/0001-error_print_progname.patch
>  delete mode 100644 package/gettext-gnu/0002-restore-the-ability-to-buld-gettext-tools-seperately-part1.patch
>  delete mode 100644 package/libtextstyle/libtextstyle.hash
>  delete mode 100644 package/libtextstyle/libtextstyle.mk

I moved the removal of libtextstyle to aseparate commit.

[--SNIP--]
> diff --git a/package/gettext-gnu/gettext-gnu.mk b/package/gettext-gnu/gettext-gnu.mk
> index 9a1eabd0df..215e6a7427 100644
> --- a/package/gettext-gnu/gettext-gnu.mk
> +++ b/package/gettext-gnu/gettext-gnu.mk
[--SNIP--]
> @@ -55,7 +53,7 @@ endif
>  # For the target version, we only need the runtime, and for the host
>  # version, we only need the tools.
>  GETTEXT_GNU_SUBDIR = gettext-runtime
> -HOST_GETTEXT_GNU_SUBDIR = gettext-tools
> +HOST_GETTEXT_GNU_SUBDIR = .

You forgot to update the comment right above, so I did it.

Applied to next, thanks.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot