From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: buildroot@buildroot.org
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Julien Olivain <ju.o@free.fr>,
James Hilliard <james.hilliard1@gmail.com>,
Adam Duskett <aduskett@gmail.com>
Subject: Re: [Buildroot] [PATCH] package/nftables: fix the build of the pyhon bindings
Date: Sun, 20 Aug 2023 11:46:47 +0200 [thread overview]
Message-ID: <20230820094647.GH1778688@scaer> (raw)
In-Reply-To: <20230817191130.1022405-1-yann.morin.1998@free.fr>
All,
On 2023-08-17 21:11 +0200, Yann E. MORIN spake thusly:
[--SNIP--]
> Instead, we split the pyhon bindings to their own package.
[--SNIP--]
> diff --git a/package/nftables/nftables.mk b/package/nftables/nftables.mk
> index b0a14bd429..aa88203ab5 100644
> --- a/package/nftables/nftables.mk
> +++ b/package/nftables/nftables.mk
> @@ -42,13 +42,6 @@ else
> NFTABLES_CONF_OPTS += --without-json
> endif
>
> -ifeq ($(BR2_PACKAGE_PYTHON3),y)
> -NFTABLES_CONF_OPTS += --enable-python
> -NFTABLES_DEPENDENCIES += python3
> -else
> -NFTABLES_CONF_OPTS += --disable-python
I moved --disable-python into the unconditional _CONF_OPTS.
Applied to master, thanks.
Regards,
Yann E. MORIN.
> -endif
> -
> NFTABLES_CONF_ENV = LIBS="$(NFTABLES_LIBS)"
>
> define NFTABLES_LINUX_CONFIG_FIXUPS
> @@ -58,3 +51,6 @@ define NFTABLES_LINUX_CONFIG_FIXUPS
> endef
>
> $(eval $(autotools-package))
> +
> +# Legacy: we used to handle it in this .mk
> +include package/nftables/nftables-python/nftables-python.mk
> --
> 2.25.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-08-20 9:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 19:11 [Buildroot] [PATCH] package/nftables: fix the build of the pyhon bindings Yann E. MORIN
2023-08-20 9:46 ` Yann E. MORIN [this message]
2023-09-12 21:21 ` Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2023-08-16 18:09 Yann E. MORIN
2023-08-16 19:09 ` Yann E. MORIN
2023-08-16 19:59 ` Julien Olivain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230820094647.GH1778688@scaer \
--to=yann.morin.1998@free.fr \
--cc=aduskett@gmail.com \
--cc=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
--cc=ju.o@free.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox