From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Bartosz Bilas <b.bilas@grinn-global.com>
Cc: thomas.petazzoni@bootlin.com, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/host-gdb: disable source-highlight
Date: Sun, 20 Aug 2023 15:35:31 +0200 [thread overview]
Message-ID: <20230820133531.GJ1778688@scaer> (raw)
In-Reply-To: <20230818063521.6191-1-b.bilas@grinn-global.com>
Bartosz, All,
On 2023-08-18 08:35 +0200, Bartosz Bilas spake thusly:
> This is the follow-up commit to the 4de60e4 which disables
> sourcehighlight dependency for the target GDB package.
> Do the same for the host variant to be sure that this
> won't be picked up from the host system.
>
> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
> ---
> package/gdb/gdb.mk | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk
> index cee7b37bcd..d9bfb39a41 100644
> --- a/package/gdb/gdb.mk
> +++ b/package/gdb/gdb.mk
> @@ -255,7 +255,8 @@ HOST_GDB_CONF_OPTS = \
> --with-system-zlib \
> --with-curses \
> --without-mpfr \
> - $(GDB_DISABLE_BINUTILS_CONF_OPTS)
> + $(GDB_DISABLE_BINUTILS_CONF_OPTS) \
> + --disable-source-highlight
We like it better (but do not have clear rules bouat it) when the
unconditional options are passed first, and conditional ones last.
So I've inverted the order, and applied to master, thanks.
Regards,
Yann E. MORIN.
> ifeq ($(BR2_PACKAGE_HOST_GDB_TUI),y)
> HOST_GDB_CONF_OPTS += --enable-tui
> --
> 2.41.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-08-20 13:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 6:35 [Buildroot] [PATCH] package/host-gdb: disable source-highlight Bartosz Bilas
2023-08-20 13:35 ` Yann E. MORIN [this message]
2023-09-12 6:08 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230820133531.GJ1778688@scaer \
--to=yann.morin.1998@free.fr \
--cc=b.bilas@grinn-global.com \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox