From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Kilian Zinnecker <kilian.zinnecker@mail.de>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/1] configs/rock5b: Add patches to fix gcc12 warnings
Date: Sun, 20 Aug 2023 21:25:57 +0200 [thread overview]
Message-ID: <20230820192557.GQ1778688@scaer> (raw)
In-Reply-To: <2899600.e9J7NaK4W3@kilian-aisec>
Kilian, All,
On 2023-08-20 21:09 +0200, Kilian Zinnecker spake thusly:
> > Also, it misses your own Sign-off line:
> Thanks, I was absolutely unaware, that adding a signed-of-by in case one
> commits other's patches as patch files was necessary
Yes, the SoB line shows who handled the patch along the way it took to
us; you are part of the chain. In the DCO, that's be clause (b):
https://developercertificate.org/
By making a contribution to this project, I certify that:
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
> and also that an upstream
> link must be provided.
Having an upstream tag helps track whether a specific patch is still
needed when the versions of components are updated.
This upstream tag is a relatively recent addition, so people are getting
hit by it, no worries (I caught it as I have a git hook that runs a
bunch of checks on each patch I apply or commit I make).
Regards,
Yann E. MORIN.
> I tried again - hopefully I did it right.
>
> I send a v3 of the patch.
>
> Thanks and best regards,
> Kilian
>
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-08-20 19:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-20 15:20 [Buildroot] [PATCH v2 0/1] Fix Rock 5B build, broken by gcc 12 warnings Kilian Zinnecker via buildroot
2023-08-20 15:20 ` [Buildroot] [PATCH v2 1/1] configs/rock5b: Add patches to fix gcc12 warnings Kilian Zinnecker via buildroot
2023-08-20 16:08 ` Yann E. MORIN
2023-08-20 19:09 ` Kilian Zinnecker via buildroot
2023-08-20 19:25 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230820192557.GQ1778688@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=kilian.zinnecker@mail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox