From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Joel Stanley <joel@jms.id.au>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] arch/powerpc: drop ABI selection
Date: Sun, 20 Aug 2023 23:23:09 +0200 [thread overview]
Message-ID: <20230820232309.6a51f2fc@windsurf> (raw)
In-Reply-To: <20230820163029.2720609-1-yann.morin.1998@free.fr>
On Sun, 20 Aug 2023 18:30:29 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> Since it was introduced in 5a6087d62e5c (toolchain: add powerpc SPE ABI
> support), the CLASSIC vs. SPE choice for the ABI was never really a
> choice: CPU without SPE could only use the CLASSIC ABI, while CPUs with
> SPE could only use the SPE ABI.
>
> Commit b4c824562bb1 (powerpc: add BR2_POWERPC_CPU_HAS_SPE to replace
> adhoc deps/checks) added a blind option that CPUs with SPE would select
> rather than duplicate the ad-hoc dependencies in both CLASSIC and SPE
> ABI options. Since then, it was even more obvious that the ABI choice
> was really not a choice, as the two options have mutually exclusive
> conditions.
>
> Drop the useless choice, and directly use the blind option as selected
> by the specific CPUs.
>
> We don't need legacy handling, because the situation fixes itself.
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Joel Stanley <joel@jms.id.au>
> ---
> arch/Config.in.powerpc | 15 ---------------
> package/Makefile.in | 2 +-
> package/gcc/Config.in.host | 10 +++++-----
> package/gcc/gcc.mk | 2 +-
> package/glibc/Config.in | 2 +-
> package/musl/Config.in | 2 +-
> 6 files changed, 9 insertions(+), 24 deletions(-)
Applied to next, thanks. To be honest, I think we should drop support
for SPE PowerPC platforms. This requires keeping a gcc 8.x around,
which is really annoying.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-08-20 21:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-20 16:30 [Buildroot] [PATCH] arch/powerpc: drop ABI selection Yann E. MORIN
2023-08-20 21:23 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230820232309.6a51f2fc@windsurf \
--to=buildroot@buildroot.org \
--cc=joel@jms.id.au \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox