From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: Christian Stewart <christian@aperture.us>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/crun: fix linking with libargp
Date: Sun, 20 Aug 2023 23:42:04 +0200 [thread overview]
Message-ID: <20230820234204.75b4af22@windsurf> (raw)
In-Reply-To: <20230820152639.3867011-1-bernd@kuhls.net>
Hello Bernd,
On Sun, 20 Aug 2023 17:26:39 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:
> Fixes:
> http://autobuild.buildroot.net/results/45f/45ff44284565c8e7deecfdc93995ec0ae4e89e2c/
>
> The bug existed since the dependency to argp-standalone was added with
> commit 0d9f268424558c37cd9538596358a537cd2f882d. The oldest build error
> I could find occured on Nov, 9th, 2022:
> http://autobuild.buildroot.net/results/ebe/ebea5d76c615d8509f87238d449e66da214fed73/
>
> Please note that using $LIBS does not fix the problem.
>
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
> package/crun/crun.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/crun/crun.mk b/package/crun/crun.mk
> index 15438a44b3..9d904ccf1b 100644
> --- a/package/crun/crun.mk
> +++ b/package/crun/crun.mk
> @@ -17,6 +17,7 @@ CRUN_CONF_OPTS = --disable-embedded-yajl
>
> ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y)
> CRUN_DEPENDENCIES += argp-standalone
> +CRUN_CONF_ENV += LDFLAGS=$(TARGET_NLS_LIBS)
This looks extremely strange. TARGET_NLS_LIBS is either empty, or
contains -lintl. How is that related to argp-standalone, and how can it
resolve the argp-standalone issue?
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-08-20 21:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-20 15:26 [Buildroot] [PATCH 1/1] package/crun: fix linking with libargp Bernd Kuhls
2023-08-20 21:42 ` Thomas Petazzoni via buildroot [this message]
[not found] ` <20230820234204.75b4af22__33285.4256777623$1692567752$gmane$org@windsurf>
2023-08-21 5:26 ` Bernd Kuhls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230820234204.75b4af22@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd@kuhls.net \
--cc=christian@aperture.us \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox