From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/shared-mime-info: link with -latomic if needed
Date: Sun, 20 Aug 2023 23:45:21 +0200 [thread overview]
Message-ID: <20230820234521.008e25e8@windsurf> (raw)
In-Reply-To: <20230820154041.3984862-1-bernd@kuhls.net>
On Sun, 20 Aug 2023 17:40:41 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:
> Buildroot commit 3f9622fe3d85b4d9f734b879abc1d485afea19b2 added an
> optional dependency to libatomic for libglib2 which caused the build
> error fixed with this patch since glib-2.0.pc does not contain any
> information about libatomic.
>
> Fixes:
> http://autobuild.buildroot.net/results/d25/d2563ce649188cec2025e4fc6e58c4bbd98ff939/
>
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
> package/shared-mime-info/shared-mime-info.mk | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/package/shared-mime-info/shared-mime-info.mk b/package/shared-mime-info/shared-mime-info.mk
> index 9932bd2db0..a9713ee639 100644
> --- a/package/shared-mime-info/shared-mime-info.mk
> +++ b/package/shared-mime-info/shared-mime-info.mk
> @@ -25,6 +25,11 @@ SHARED_MIME_INFO_LICENSE_FILES = COPYING
> HOST_SHARED_MIME_INFO_DEPENDENCIES = \
> host-pkgconf host-intltool host-libxml2 host-libglib2
>
> +# Uses __atomic_compare_exchange_4 from libglib2
> +ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
> +SHARED_MIME_INFO_CONF_ENV += LIBS=-latomic
> +endif
Thanks, but I continue to think that this is not the proper way of
fixing this. The proper way is for glib-2.0.pc to list -latomic in its
Libs.private, so that it gets picked-up by shared-mime-info when
statically linking.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-08-20 21:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-20 15:40 [Buildroot] [PATCH 1/1] package/shared-mime-info: link with -latomic if needed Bernd Kuhls
2023-08-20 21:45 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230820234521.008e25e8@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd@kuhls.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox