From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Waldemar Brodkorb <wbx@openadk.org>
Cc: Grzegorz Blach <grzegorz@blach.pl>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/f2fs-tools: fix musl compile error
Date: Tue, 22 Aug 2023 22:06:08 +0200 [thread overview]
Message-ID: <20230822220608.001dae37@windsurf> (raw)
In-Reply-To: <ZNkQMgmLXTtuItPp@waldemar-brodkorb.de>
On Sun, 13 Aug 2023 19:17:38 +0200
Waldemar Brodkorb <wbx@openadk.org> wrote:
> +ifeq ($(BR2_TOOLCHAIN_USES_MUSL),y)
> +F2FS_TOOLS_CONF_ENV += ac_cv_func_lseek64=yes
> +endif
I am not really happy with this, because it's really a workaround. I am
not sure to fully grasp what the issue is. Apparently, in commit
https://git.musl-libc.org/cgit/musl/commit/?id=246f1c811448f37a44b41cd8df8d0ef9736d95f4
in musl, the lseek64 -> lseek alias was removed, and now there is some
dynamic linker trickery instead.
I think the issue is that what f2fs-tools does is wrong, and this is
what needs to be fixed. I would suggest to reach out to the musl
community, as they are usually very good at suggesting how to do things
right.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-08-22 20:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-13 17:17 [Buildroot] [PATCH] package/f2fs-tools: fix musl compile error Waldemar Brodkorb
2023-08-22 20:06 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230822220608.001dae37@windsurf \
--to=buildroot@buildroot.org \
--cc=grzegorz@blach.pl \
--cc=thomas.petazzoni@bootlin.com \
--cc=wbx@openadk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox