From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/mmc-utils: fix build failure with _FORTIFY_SOURCE=3
Date: Tue, 22 Aug 2023 22:20:33 +0200 [thread overview]
Message-ID: <20230822222033.3ef8fd5d@windsurf> (raw)
In-Reply-To: <20230809210338.1330998-1-giulio.benetti@benettiengineering.com>
On Wed, 9 Aug 2023 23:03:38 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> +# disable _FORTIFY_SOURCE=3 and set it to 2
> +ifeq ($(BR2_FORTIFY_SOURCE_3),y)
> +MMC_UTILS_CFLAGS += -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2
> +endif
This is a work-around, not a proper fix, and actually the following
defconfig builds just fine today:
BR2_arm=y
BR2_cortex_a9=y
BR2_ARM_ENABLE_VFP=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
BR2_FORTIFY_SOURCE_3=y
BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_MMC_UTILS=y
# BR2_TARGET_ROOTFS_TAR is not set
So there is really no reason to globally override _FORTIFY_SOURCE=3 for
mmc-utils, it builds fine at least in some situations. So it needs to
be narrowed down a little bit further, up to the point where we can see
if it's a glibc bug, or a gcc bug, possibly architecture specific.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-08-22 20:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 21:03 [Buildroot] [PATCH] package/mmc-utils: fix build failure with _FORTIFY_SOURCE=3 Giulio Benetti
2023-08-22 20:20 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230822222033.3ef8fd5d@windsurf \
--to=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox