From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] Makefile: remove $(TARGET_DIR)/usr/mkspecs in target-finalize
Date: Thu, 24 Aug 2023 23:17:43 +0200 [thread overview]
Message-ID: <20230824211743.GH3722679@scaer> (raw)
In-Reply-To: <20230824210800.1589677-1-thomas.petazzoni@bootlin.com>
On 2023-08-24 23:08 +0200, Thomas Petazzoni via buildroot spake thusly:
> qt6base installs things in /usr/mkspecs, but also the soon to be added
> qt6core5compat, and the existing package qwt as well. So let's move
> the removal of /usr/mkspecs in target-finalize, where we already
> remove lots of development-related directories.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> Makefile | 1 +
> package/qwt/qwt.mk | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index da52a51716..f255b1e443 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -747,6 +747,7 @@ endif
> rm -rf $(TARGET_DIR)/usr/info $(TARGET_DIR)/usr/share/info
> rm -rf $(TARGET_DIR)/usr/doc $(TARGET_DIR)/usr/share/doc
> rm -rf $(TARGET_DIR)/usr/share/gtk-doc
> + rm -rf $(TARGET_DIR)/usr/mkspecs
Why don't you make that a QT6BASE_TARGET_FINALIZE_HOOKS ?
I'm warry of adding package-specific cleanup in the generic code, and we
introduced FOO_TARGET_FINALIZE_HOOKS specifically for such use-cases.
Regards,
Yann E. MORIN.
> rmdir $(TARGET_DIR)/usr/share 2>/dev/null || true
> ifneq ($(BR2_ENABLE_DEBUG):$(BR2_STRIP_strip),y:)
> rm -rf $(TARGET_DIR)/lib/debug $(TARGET_DIR)/usr/lib/debug
> diff --git a/package/qwt/qwt.mk b/package/qwt/qwt.mk
> index 9f0b78655f..f344ca4e3a 100644
> --- a/package/qwt/qwt.mk
> +++ b/package/qwt/qwt.mk
> @@ -58,7 +58,6 @@ endef
>
> define QWT_INSTALL_TARGET_CMDS
> $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) install INSTALL_ROOT=$(TARGET_DIR)
> - rm -Rf $(TARGET_DIR)/usr/mkspecs
> endef
>
> $(eval $(qmake-package))
> --
> 2.41.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-08-24 21:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 21:08 [Buildroot] [PATCH] Makefile: remove $(TARGET_DIR)/usr/mkspecs in target-finalize Thomas Petazzoni via buildroot
2023-08-24 21:17 ` Yann E. MORIN [this message]
2023-12-28 20:33 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230824211743.GH3722679@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox