From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Sebastian Weyer <sebastian.weyer@smile.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v6 2/3] package/nushell: Add default configs
Date: Wed, 30 Aug 2023 22:36:39 +0200 [thread overview]
Message-ID: <20230830223639.76515cbd@windsurf> (raw)
In-Reply-To: <20230308131554.642965-2-sebastian.weyer@smile.fr>
On Wed, 8 Mar 2023 14:15:52 +0100
Sebastian Weyer <sebastian.weyer@smile.fr> wrote:
> +define NUSHELL_INSTALL_DEFAULT_CONFIG
> + $(INSTALL) -m 0644 -D $(@D)/crates/nu-utils/src/sample_config/default_config.nu \
> + $(TARGET_DIR)/root/.config/nushell/config.nu
> + $(INSTALL) -m 0644 -D $(@D)/crates/nu-utils/src/sample_config/default_env.nu \
> + $(TARGET_DIR)/root/.config/nushell/env.nu
> +endef
> +NUSHELL_POST_INSTALL_TARGET_HOOKS += NUSHELL_INSTALL_DEFAULT_CONFIG
I did not apply this patch, because it installs a configuration only
for the root user, so its usefulness seems quite limited, and we
essentially never install special configuration specifically for the
root user (there's a very old exception in the fluxbox package, but
that's it).
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-08-30 20:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 13:15 [Buildroot] [PATCH v6 1/3] package/nushell: new package Sebastian Weyer
2023-03-08 13:15 ` [Buildroot] [PATCH v6 2/3] package/nushell: Add default configs Sebastian Weyer
2023-08-30 20:36 ` Thomas Petazzoni via buildroot [this message]
2023-03-08 13:15 ` [Buildroot] [PATCH v6 3/3] support/testing/tests/package/test_nu.py: New runtime test Sebastian Weyer
2023-08-30 20:37 ` Thomas Petazzoni via buildroot
2023-08-30 20:35 ` [Buildroot] [PATCH v6 1/3] package/nushell: new package Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230830223639.76515cbd@windsurf \
--to=buildroot@buildroot.org \
--cc=sebastian.weyer@smile.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox