From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Köry Maincent via buildroot" <buildroot@buildroot.org>
Cc: "Köry Maincent" <kory.maincent@bootlin.com>,
"Jens Kleintje" <scooby22@web.de>
Subject: Re: [Buildroot] [PATCH] package/linux-firmware: Add new option for Marvell prestera firmware
Date: Sat, 2 Sep 2023 10:24:40 +0200 [thread overview]
Message-ID: <20230902102440.3d9a22b3@windsurf> (raw)
In-Reply-To: <20230831081517.546751-1-kory.maincent@bootlin.com>
Hello Köry,
On Thu, 31 Aug 2023 10:15:16 +0200
Köry Maincent via buildroot <buildroot@buildroot.org> wrote:
> From: Kory Maincent <kory.maincent@bootlin.com>
>
> Add the Marvell prestera ethernet cards firmwares.
>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> package/linux-firmware/Config.in | 5 +++++
> package/linux-firmware/linux-firmware.mk | 5 +++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/package/linux-firmware/Config.in b/package/linux-firmware/Config.in
> index 3ae72564cc..402e75c890 100644
> --- a/package/linux-firmware/Config.in
> +++ b/package/linux-firmware/Config.in
> @@ -513,6 +513,11 @@ config BR2_PACKAGE_LINUX_FIRMWARE_RTL_8169
> help
> Firmware files for Realtek 8169 gigabit ethernet cards
>
> +config BR2_PACKAGE_LINUX_FIRMWARE_MARVELL_PRESTERA
> + bool "Marvell Prestera"
> + help
> + Firmware files for Marvell Prestera ethernet cards
> +
Alphabetic ordering here was not correct so I fixed that up.
> +ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_MARVELL_PRESTERA),y)
> +LINUX_FIRMWARE_FILES += \
> + mrvl/prestera/mvsw_prestera_fw*.img
You forgot the license file here, and adding its hash. I fixed that up
as well.
One thing I wondered is:
-rw-r--r--. 1 thomas thomas 17M 4 août 12:33 mvsw_prestera_fw_arm64-v4.1.img
-rwxr-xr-x. 1 thomas thomas 14M 4 août 12:33 mvsw_prestera_fw-v2.0.img
-rwxr-xr-x. 1 thomas thomas 14M 4 août 12:33 mvsw_prestera_fw-v3.0.img
-rw-r--r--. 1 thomas thomas 15M 4 août 12:33 mvsw_prestera_fw-v4.0.img
-rw-r--r--. 1 thomas thomas 15M 4 août 12:33 mvsw_prestera_fw-v4.1.img
i.e, each FW file is ~15 MB, but only one will actually be loaded by
the driver. Not sure if this warrants a Config.in for each FW version,
or if we just let people remove the firmware files they don't use in a
post-build script.
Anyway, I applied your patch to next, with the fixes described above.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-09-02 8:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 8:15 [Buildroot] [PATCH] package/linux-firmware: Add new option for Marvell prestera firmware Köry Maincent via buildroot
2023-09-02 8:24 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230902102440.3d9a22b3@windsurf \
--to=buildroot@buildroot.org \
--cc=kory.maincent@bootlin.com \
--cc=scooby22@web.de \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox