Re: [Buildroot] [PATCH/next 2/7] package/vulkan-loader: new package

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Adam Duskett <aduskett@gmail.com>
Cc: Bernd Kuhls <bernd@kuhls.net>,
	Samuel Martin <s.martin49@gmail.com>,
	Julien Corjon <corjon.j@ecagroup.com>,
	buildroot@buildroot.org,
	Giulio Benetti <giulio.benetti@benettiengineering.com>,
	Jesse Van Gavere <jesseevg@gmail.com>,
	Romain Naour <romain.naour@gmail.com>
Subject: Re: [Buildroot] [PATCH/next 2/7] package/vulkan-loader: new package
Date: Sat, 2 Sep 2023 12:01:33 +0200	[thread overview]
Message-ID: <20230902120133.71a0809c@windsurf> (raw)
In-Reply-To: <20230830195446.3958486-2-aduskett@gmail.com>

Hello Adam,

On Wed, 30 Aug 2023 13:54:41 -0600
Adam Duskett <aduskett@gmail.com> wrote:

> diff --git a/package/vulkan-loader/vulkan-loader.hash b/package/vulkan-loader/vulkan-loader.hash
> new file mode 100644
> index 0000000000..e09ecda8a9
> --- /dev/null
> +++ b/package/vulkan-loader/vulkan-loader.hash
> @@ -0,0 +1,3 @@
> +# Locally calculated
> +sha256  3bbaa5ee64058a89949eb777de66ce94bfe3141892514172cfc9451c756802d5  vulkan-loader-1.3.262.tar.gz
> +sha256  43c0a37e6a0fa7ff3c843b3ec5a4fac84b712558ddac103fbd4c1649662a9ece  LICENSE.txt
> diff --git a/package/vulkan-loader/vulkan-loader.mk b/package/vulkan-loader/vulkan-loader.mk
> new file mode 100644
> index 0000000000..d87e57ebd4
> --- /dev/null
> +++ b/package/vulkan-loader/vulkan-loader.mk
> @@ -0,0 +1,45 @@
> +################################################################################
> +#
> +# vulkan-loader
> +#
> +################################################################################
> +
> +VULKAN_LOADER_VERSION = $(VULKAN_HEADERS_VERSION)
> +VULKAN_LOADER_SITE = $(call github,KhronosGroup,Vulkan-Loader,v$(VULKAN_LOADER_VERSION))
> +VULKAN_LOADER_LICENSE = Apache-2.0
> +VULKAN_LOADER_LICENSE_FILES = LICENSE.txt
> ++VULKAN_LOADER_INSTALL_STAGING = YES

  ^^^ typo here, there was a "+" at the beginning of the line. Funnily,
  make did not complain about this, and just ignored this line, so
  vulkan-loader was not installed into staging.

I fixed that and applied to next. However, could you have a look at
whether we need to keep /usr/share/vulkan/registry/? It contains
JSON/Python stuff, I don't think it's useful at runtime?

Also, what is /usr/share/vulkan/icd.d/ ? I see there's an ICD tool in
vulkan-tools. Is that related? Needed on the target?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot