From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Neal Frager via buildroot <buildroot@buildroot.org>
Cc: Bradley.Gamble@entrust.com, ibai.erkiaga-elorza@amd.com,
michal.simek@amd.com, Neal Frager <neal.frager@amd.com>,
david.evans@ebv.com, dylan.bespalko@amd.com,
luca.ceresoli@bootlin.com
Subject: Re: [Buildroot] [PATCH v2 1/1] configs/zynqmp_kria_kr260_defconfig: new defconfig
Date: Sat, 2 Sep 2023 14:56:04 +0200 [thread overview]
Message-ID: <20230902145604.284bda77@windsurf> (raw)
In-Reply-To: <20230830085859.524233-1-neal.frager@amd.com>
Hello Neal,
On Wed, 30 Aug 2023 09:58:59 +0100
Neal Frager via buildroot <buildroot@buildroot.org> wrote:
> diff --git a/board/zynqmp/kria/kr260/patches/uboot/1-3-firmware-zynqmp-Add-support-to-check-feature.patch b/board/zynqmp/kria/kr260/patches/uboot/1-3-firmware-zynqmp-Add-support-to-check-feature.patch
> new file mode 100644
> index 0000000000..994dcf8777
> --- /dev/null
> +++ b/board/zynqmp/kria/kr260/patches/uboot/1-3-firmware-zynqmp-Add-support-to-check-feature.patch
Could you please re-generate all patches with 'git format-patch -N' ?
This way:
- They will not have zillions of e-mail headers
- The file names will have a proper naming
- The patch titles will not have 1/1
Other than that, I think this looks good to me. Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-09-02 12:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 8:58 [Buildroot] [PATCH v2 1/1] configs/zynqmp_kria_kr260_defconfig: new defconfig Neal Frager via buildroot
2023-09-02 12:56 ` Thomas Petazzoni via buildroot [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-12-07 14:06 Neal Frager via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230902145604.284bda77@windsurf \
--to=buildroot@buildroot.org \
--cc=Bradley.Gamble@entrust.com \
--cc=david.evans@ebv.com \
--cc=dylan.bespalko@amd.com \
--cc=ibai.erkiaga-elorza@amd.com \
--cc=luca.ceresoli@bootlin.com \
--cc=michal.simek@amd.com \
--cc=neal.frager@amd.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox