From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Knight <james.d.knight@live.com>
Cc: Ricardo Martincoski <ricardo.martincoski@datacom.com.br>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/1] utils/check-package: cleanup line reading
Date: Sat, 2 Sep 2023 17:48:59 +0200 [thread overview]
Message-ID: <20230902174859.4e92c381@windsurf> (raw)
In-Reply-To: <CYYP221MB114006AE3D1C77F421E44B43A0EBA@CYYP221MB1140.NAMP221.PROD.OUTLOOK.COM>
On Sat, 2 Sep 2023 08:47:49 -0400
James Knight <james.d.knight@live.com> wrote:
> Cleanup the implementation for reading lines by having files processed
> in context managers and utilizing the iterable file object for line
> reading (instead of needing to call `readlines()`).
>
> Signed-off-by: James Knight <james.d.knight@live.com>
> ---
> Changes v1 -> v2:
> - This change drops the use of an `fstate` instance which should not
> have been added in this initial/first patch (of a four-patch
> series). (mentioned by Thomas Petazzoni)
> - Only this first patch is being resubmitted as this first patch can
> be applied by itself and the remaining patches are in discussion.
> ---
> utils/check-package | 22 ++++++++++++----------
> 1 file changed, 12 insertions(+), 10 deletions(-)
Applied to next, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-09-02 15:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-02 12:47 [Buildroot] [PATCH v2 1/1] utils/check-package: cleanup line reading James Knight
2023-09-02 15:48 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230902174859.4e92c381@windsurf \
--to=buildroot@buildroot.org \
--cc=james.d.knight@live.com \
--cc=ricardo.martincoski@datacom.com.br \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox