Re: [Buildroot] [PATCH 1/1] package/docker-engine: optionally include zfs graphdriver

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Audun-Marius,

Thanks for your patch! Sorry for the delay in getting back to you. See
below some comments.

On Sat, 15 Jul 2023 18:17:36 +0800
Audun-Marius Gangstø via buildroot <buildroot@buildroot.org> wrote:

> Hello,
> 
> Since zfs is in buildroot now, I thought it would be good to enable the 
> graphdriver in docker-engine.
> 
> Thank you

The commit log shouldn't be an e-mail, but just a description of the
change. So basically no "Hello", no "Thank you", and no first person
sentence. Something like:

Now that ZFS is packaged in Buildroot, this commit adds an option to
enable ZFS support in docker-engine.

> 
> diff --git a/package/docker-engine/docker-engine.mk b/package/docker-engine/
> docker-engine.mk
> index f904793a..0647a560 100644
> --- a/package/docker-engine/docker-engine.mk
> +++ b/package/docker-engine/docker-engine.mk
> @@ -23,7 +23,7 @@ DOCKER_ENGINE_LDFLAGS = \
>         -X $(DOCKER_ENGINE_GOMOD)/dockerversion.InitCommitID="" \
>         -X $(DOCKER_ENGINE_GOMOD)/dockerversion.Version="$
> (DOCKER_ENGINE_VERSION)"
>  
> -DOCKER_ENGINE_TAGS = cgo exclude_graphdriver_zfs
> +DOCKER_ENGINE_TAGS = cgo
>  DOCKER_ENGINE_BUILD_TARGETS = cmd/dockerd cmd/docker-proxy
>  
>  ifeq ($(BR2_PACKAGE_LIBAPPARMOR),y)
> @@ -56,6 +56,12 @@ else
>  DOCKER_ENGINE_TAGS += exclude_graphdriver_vfs
>  endif
>  
> +ifeq ($(BR2_PACKAGE_DOCKER_ENGINE_DRIVER_ZFS),y)

Where is this option added? I think you forgot to "git add" your
changes in the Config.in file.

Could you fix those issues and sent an updated version of your patch? 

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot