From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>,
Spenser Gilliland <spenser@gillilanding.com>,
Sebastian WEYER <sebastian.weyer@smile.fr>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/libdecor: new package
Date: Sat, 2 Sep 2023 19:17:33 +0200 [thread overview]
Message-ID: <20230902191733.3e09f99f@windsurf> (raw)
In-Reply-To: <20230716145003.339645-1-bernd@kuhls.net>
Hello,
On Sun, 16 Jul 2023 16:50:02 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:
> Needed for wayland support in mesa3d-demos.
>
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
I've applied after doing some changes/fixes, see below.
> ---
> package/Config.in | 1 +
> package/libdecor/Config.in | 25 +++++++++++++++++++++++++
> package/libdecor/libdecor.hash | 3 +++
> package/libdecor/libdecor.mk | 22 ++++++++++++++++++++++
> 4 files changed, 51 insertions(+)
> create mode 100644 package/libdecor/Config.in
> create mode 100644 package/libdecor/libdecor.hash
> create mode 100644 package/libdecor/libdecor.mk
Entry in DEVELOPERS file was missing.
> +LIBDECOR_VERSION = 0.1.1
> +LIBDECOR_SITE = https://gitlab.freedesktop.org/libdecor/libdecor/-/archive/$(LIBDECOR_VERSION)
> +LIBDECOR_LICENSE = MIT
> +LIBDECOR_LICENSE_FILES = LICENSE
> +LIBDECOR_INSTALL_STAGING = YES
> +LIBDECOR_DEPENDENCIES = cairo dbus pango wayland wayland-protocols
You're adding dbus as a mandatory dependency here, but it's not
selected in Config.in and it's actually an optional dependency.
> +LIBDECOR_CONF_OPTS = -Ddemo=false
> +
> +ifeq ($(BR2_PACKAGE_DBUS),yx)
This condition would never be true due to the typo "yx" instead of just "y".
I fixed both issues and applied to master, as this package is needed to
fix issues in master.
Best regards,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-09-02 17:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-16 14:50 [Buildroot] [PATCH 1/2] package/libdecor: new package Bernd Kuhls
2023-07-16 14:50 ` [Buildroot] [PATCH 2/2] package/mesa3d-demos: add optional dependencies for wayland support Bernd Kuhls
2023-09-02 17:19 ` Thomas Petazzoni via buildroot
2023-07-25 8:54 ` [Buildroot] [PATCH 1/2] package/libdecor: new package Sebastian WEYER
2023-09-02 17:18 ` Thomas Petazzoni via buildroot
2023-09-02 17:17 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230902191733.3e09f99f@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd@kuhls.net \
--cc=eric.le.bihan.dev@free.fr \
--cc=sebastian.weyer@smile.fr \
--cc=spenser@gillilanding.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox