Re: [Buildroot] [PATCH] package/luajit: bump to version 41fb94defa8f830ce69a8122b03f6ac3216d392a

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Francois, All,

On 2023-09-08 08:49 +0200, Francois Perrad spake thusly:
> The LuaJIT project switches to a rolling release scheme.
> Now, the version contains the timestamp of the latest commit.

Containing a timstamp is not a problem per-s. The problem is that is
done with a .gitatrribute, so is replaced on the github side, and this
has proven to be non-reproducible.

The format is %ct, which is a the committer's UNIX timestamp. In
practice, that one is reproducible, but we don't want to get bitten,
so we want to use a constanto, see below...

> So, we need to switch to the SITE_METHOD to git.
> 
> The timestamp can be seen in build log:
> ==== Successfully installed LuaJIT 2.1.1693350652 to /usr ====
                                         ^^^^^^^^^^^
This is not the tiemstamp that you would have expected, see below too...

> 
> diff COPYRIGHT:
> -Copyright (C) 2005-2022 Mike Pall. All rights reserved.
> +Copyright (C) 2005-2023 Mike Pall. All rights reserved.

Please, don't write unindented diff-like blurbs in commit logs; they
screw up patchwork:

    https://patchwork.ozlabs.org/project/buildroot/patch/20230908064944.2558686-1-francois.perrad@gadz.org/

If you ant to provide a diif-like blurb (the one you provide, indented
it. Besides, a commit log is not a machine-readable section; it's meant
for users to review and udnerstand the change, so I'd prefer to read:

    Hash for the COPYRIGHT file changed, due to an update in the
    copyright years.

That is enough for us to know that you actually looked at the diff, and
that is enough to understand that the licensing terms did not change,
which is the whole point of trackign the hashes for the license files:
to detec ta change in licensing terms.

> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
[--SNIP--]
> diff --git a/package/luajit/luajit.mk b/package/luajit/luajit.mk
> index 2a27aa505..db3bdc913 100644
> --- a/package/luajit/luajit.mk
> +++ b/package/luajit/luajit.mk
> @@ -4,8 +4,9 @@
>  #
>  ################################################################################
>  
> -LUAJIT_VERSION = 8635cbabf3094c4d8bd00578c7d812bea87bb2d3
> -LUAJIT_SITE = $(call github,LuaJIT,LuaJIT,$(LUAJIT_VERSION))
> +LUAJIT_VERSION = 41fb94defa8f830ce69a8122b03f6ac3216d392a
> +LUAJIT_SITE_METHOD = git
> +LUAJIT_SITE = https://github.com/LuaJIT/LuaJIT.git
>  LUAJIT_LICENSE = MIT
>  LUAJIT_LICENSE_FILES = COPYRIGHT
>  LUAJIT_CPE_ID_VENDOR = luajit
> @@ -33,6 +34,14 @@ LUAJIT_HOST_CC = $(HOSTCC) -m32
>  LUAJIT_XCFLAGS += -DLUAJIT_DISABLE_GC64
>  endif
>  
> +# emulation of git archive with .gitattributes & export-subst
> +define LUAJIT_ROLLING_VERSION
> +	cd $(LUAJIT_DL_DIR)/git && $(GIT) show -s --format=%ct $(LUAJIT_VERSION) > $(@D)/.relver

This is incorrect, for two reasons:

 1. if there is a git tree, it will not be the expected one: the archive
    Buildroot generates does not have the .git of the upstream project,
    so for in-tree builds, this would be the Buildroot git tree.

 1. there might not even be a git tree available: for out-of-tree builds
    as for Buildroot release tarballs, there will be no git tree
    available.

Here, all you are interested in is probably just the tiemstamp, which is
a constant, so;

    # Tiemstamp of the $(LUAJIT_VERSION) commit, obtained in the LuaJit
    # repo, with:   git show -s --format=%ct $(LUAJIT_VERSION)
    define LUAJIT_ROLLING_VERSION
        echo 1689194086 >$(@D)/.relver
    endef
    LUAJIT_POST_EXTRACT_HOOKS = LUAJIT_ROLLING_VERSION
    HOST_LUAJIT_POST_EXTRACT_HOOKS = LUAJIT_ROLLING_VERSION

Regards,
Yann E. MORIN.

> +endef
> +
> +LUAJIT_POST_EXTRACT_HOOKS = LUAJIT_ROLLING_VERSION
> +HOST_LUAJIT_POST_EXTRACT_HOOKS = LUAJIT_ROLLING_VERSION
> +
>  # We unfortunately can't use TARGET_CONFIGURE_OPTS, because the luajit
>  # build system uses non conventional variable names.
>  define LUAJIT_BUILD_CMDS
> -- 
> 2.39.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot