Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Daniel Lang <dalang@gmx.at>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/libssh: ignore CVE-2023-3603
Date: Fri, 8 Sep 2023 22:32:39 +0200	[thread overview]
Message-ID: <20230908223239.06963447@windsurf> (raw)
In-Reply-To: <20230906200929.291410-1-dalang@gmx.at>

Hello Daniel,

On Wed,  6 Sep 2023 22:09:27 +0200
Daniel Lang <dalang@gmx.at> wrote:

> The affected code isn't present in any release, see [0].
> 
> [0]: https://www.libssh.org/2023/07/14/cve-2023-3603-potential-null-dereference-in-libsshs-sftp-server/
> 
> Signed-off-by: Daniel Lang <dalang@gmx.at>

Here the NVD database tells us that the following CPE identifier is
affected:

  cpe:2.3:a:libssh:libssh:-:*:*:*:*:*:*:*

So the version field is not '*', but '-', and I think our pkg-stats
script doesn't do the right thing when handling '-'. I remember asking
the NVD maintainers about this, and they replied:

    The '-' in the URI 'cpe:2.3:a:ntp:ntp:-:*:*:*:*:*:*:*' is used
    because the affected version was not specified. We need to use the
    '-' when the affected version is not specified otherwise, using the
    '*' will incorrectly call all versions of NTP as vulnerable.


    The '*' is the wildcard, while the '-' is used to represent
    unspecified versions, a placeholder to an update, as explained
    earlier.

I believe right now pkg-stats handles '-' like '*', but I'm not sure
it's the right thing to do. But the answer from NVD didn't really help
because "unspecified versions" doesn't mean much.

Another thing that would be good to do in pkg-stats is warn if there is
a CVE listed in <pkg>_IGNORE_CVES, but this CVE in fact does not
affects the package. This would allow us to catch mistakes, but also
cases where a CVE was added to the ignore list, but no longer needs to
be in that list because the NVD data has been updated/improved.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-09-08 20:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-06 20:09 [Buildroot] [PATCH] package/libssh: ignore CVE-2023-3603 Daniel Lang
2023-09-08 20:32 ` Thomas Petazzoni via buildroot [this message]
2023-09-22 18:58   ` Arnout Vandecappelle via buildroot
2023-09-26  6:08 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230908223239.06963447@windsurf \
    --to=buildroot@buildroot.org \
    --cc=dalang@gmx.at \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox