From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Waldemar Brodkorb <wbx@openadk.org>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/xterm: fix compilation with uClibc
Date: Mon, 11 Sep 2023 22:55:50 +0200 [thread overview]
Message-ID: <20230911225550.4fd56980@windsurf> (raw)
In-Reply-To: <ZPQ7D+xaRQDl1n8L@waldemar-brodkorb.de>
On Sun, 3 Sep 2023 09:51:43 +0200
Waldemar Brodkorb <wbx@openadk.org> wrote:
> Compile errors out with:
> ./util.c: In function 'decode_wcwidth':
> ./util.c:5506:26: error: 'wcwidth' undeclared (first use in this function); did you mean 'mk_wcwidth'?
> 5506 | my_wcwidth = wcwidth;
> | ^~~~~~~
> | mk_wcwidth
> ./util.c:5506:26: note: each undeclared identifier is reported only once for each function it appears in
>
> uClibc only exposes wcwidth when __USE_XOPEN is defined.
According to the wcwidth manpage, it's _XOPEN_SOURCE that needs to be
defined:
SYNOPSIS
#define _XOPEN_SOURCE /* See feature_test_macros(7) */
#include <wchar.h>
int wcwidth(wchar_t c);
I guess __USE_XOPEN is a more "internal" thing.
> diff --git a/package/xterm/0001-uClibc-wcwidth.patch b/package/xterm/0001-uClibc-wcwidth.patch
> new file mode 100644
> index 0000000000..ee0416ec78
> --- /dev/null
> +++ b/package/xterm/0001-uClibc-wcwidth.patch
> @@ -0,0 +1,13 @@
> +Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> +Upstream: N/A patch sent via email
Meh these upstream projects not using Git... :/
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-09-11 20:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-03 7:51 [Buildroot] [PATCH] package/xterm: fix compilation with uClibc Waldemar Brodkorb
2023-09-11 20:55 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230911225550.4fd56980@windsurf \
--to=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wbx@openadk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox