From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/cairo: fix pthread detection
Date: Mon, 11 Sep 2023 23:06:51 +0200 [thread overview]
Message-ID: <20230911230651.4739c3d1@windsurf> (raw)
In-Reply-To: <20230729103022.378621-1-bernd@kuhls.net>
On Sat, 29 Jul 2023 12:30:22 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:
> Cairo's link check for pthreads support "must complete without warnings
> or errors to stderr":
> https://cgit.freedesktop.org/cairo/tree/build/aclocal.cairo.m4?h=1.16.0#n83
> https://cgit.freedesktop.org/cairo/tree/build/configure.ac.pthread?h=1.16.0#n137
>
> The pthread check fails with this defconfig
>
> checking for cairo's pthread feature...
> checking whether cairo's pthread feature could be enabled... no (can't link with -lpthread or -pthread)
>
> due a warning thrown by ld:
>
> /home/bernd/buildroot/output/per-package/cairo/host/bin/../lib/gcc/xtensa-buildroot-linux-uclibc/12.3.0/../../../../xtensa-buildroot-linux-uclibc/bin/ld:
> warning: /home/bernd/buildroot/br4/output/per-package/cairo/host/bin/../lib/gcc/xtensa-buildroot-linux-uclibc/12.3.0/crtendS.o:
> missing .note.GNU-stack section implies executable stack
>
> /home/bernd/buildroot/output/per-package/cairo/host/bin/../lib/gcc/xtensa-buildroot-linux-uclibc/12.3.0/../../../../xtensa-buildroot-linux-uclibc/bin/ld:
> NOTE: This behaviour is deprecated and will be removed in a future version of the linker
>
> These linker warnings were introduced by binutils 2.39:
> https://www.redhat.com/en/blog/linkers-warnings-about-executable-stacks-and-segments
>
> Silence them by adding "-Wl,-z,noexecstack" to fix cairo's pthread check
>
> Meanwhile upstream removed autoconf support on the master branch:
> https://cgit.freedesktop.org/cairo/commit/?id=efe303d9db6e24d5786c15252327811338bc9b0a
> so no need to notify them.
>
> Fixes:
> http://autobuild.buildroot.net/results/408/408a900ac01dbce145aff302c75f9f4e147f5672/
>
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
> ---
> package/cairo/cairo.mk | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
The correct fix for this was to fix gcc:
https://gitlab.com/buildroot.org/buildroot/-/commit/ab4f3fafaa839593b3efd9ea12c8ee5d9340cdeb
So I've marked this patch as Rejected. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-09-11 21:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-29 10:30 [Buildroot] [PATCH 1/1] package/cairo: fix pthread detection Bernd Kuhls
2023-09-11 21:06 ` Thomas Petazzoni via buildroot [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-02-23 15:32 Fabrice Fontaine
2023-02-23 22:47 ` Fabrice Fontaine
2023-02-23 23:00 ` Thomas Petazzoni via buildroot
2023-03-10 20:23 ` Arnout Vandecappelle
2023-09-11 21:08 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230911230651.4739c3d1@windsurf \
--to=buildroot@buildroot.org \
--cc=bernd@kuhls.net \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox