Re: [Buildroot] Fwd: [PATCH] fs/user-initrd: add new method for building customizable INITRD

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Witold,

On Wed, 13 Sep 2023 06:41:48 +0200
Wit <linuxcdeveloper@gmail.com> wrote:

> Hello All!
> 
> As for now user has not much influence on creation of contents of an
> INITRD image I've made some proof of concept of some wider idea of
> creating customizable INITRD image.
> This patch adds possibility of creating customizable INITRD image by
> selecting some of packages to install. At the moment it supports only
> glibc builds but I planned to add support for musl and uClibc as well.
> I've got also some other plans regarding this patch.
> This patch adds new submenu in "Filesystem images" main menu.
> 
> I'm sending this patch for evaluation. If the idea of this patch is ok
> for you I could take care of developing it.
> 
> Signed-off-by: Witold Kowolik <linuxcdeveloper@gmail.com>

Thanks for your proposal. A couple of comments:

(1) Your patch is line-wrapped, so difficult to review. Could you use
    git send-email to send your patches?

(2) Have you looked at Dracut and its integration in Buildroot? Because
    to me it does pretty much the same as what you're doing. We know
    Dracut's integration in Buildroot has some shortcomings, but I'd
    rather see them being resolved rather than introduce another new
    mechanism.

(3) I see you're using a Perl script. We generally try to have most of
    the Buildroot plumbing implemented either in shell or in Python.
    However, it's true that having a Python interpreter on the host is
    no longer required, while having a Perl interpreter is (which would
    go in favor of keeping a Perl script).

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot