From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Francois Perrad <fperrad@gmail.com>
Cc: buildroot@busybox.net, Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [PATCH v2] package/luajit: bump to version 41fb94defa8f830ce69a8122b03f6ac3216d392a
Date: Fri, 15 Sep 2023 22:11:52 +0200 [thread overview]
Message-ID: <20230915201152.GA2571@scaer> (raw)
In-Reply-To: <20230912185706.2605439-1-francois.perrad@gadz.org>
François, All,
+Thomas
On 2023-09-12 20:57 +0200, Francois Perrad spake thusly:
> The LuaJIT project switches to a rolling release scheme.
> Now, the version contains the timestamp of its latest commit.
>
> The timestamp can be seen in build log:
> ==== Successfully installed LuaJIT 2.1.1693350652 to /usr ====
[--SNIP--]
> diff --git a/package/luajit/luajit.mk b/package/luajit/luajit.mk
> index 2a27aa505..07cb6e015 100644
> --- a/package/luajit/luajit.mk
> +++ b/package/luajit/luajit.mk
> @@ -4,7 +4,7 @@
> #
> ################################################################################
>
> -LUAJIT_VERSION = 8635cbabf3094c4d8bd00578c7d812bea87bb2d3
> +LUAJIT_VERSION = 41fb94defa8f830ce69a8122b03f6ac3216d392a
> LUAJIT_SITE = $(call github,LuaJIT,LuaJIT,$(LUAJIT_VERSION))
In your v1, you were using the git method to do the download, but this
v2 no longer does.
We are using the github-generated archive, and that applies the
export-subst replacements on the github side, so the .relver file has
been replaced in the archive served by github. Then, see below...
[--SNIP--]
> +# emulation of git archive with .gitattributes & export-subst
> +# Timestamp of the $(LUAJIT_VERSION) commit, obtained in the LuaJit
> +# repo, with: git show -s --format=%ct $(LUAJIT_VERSION)
> +define LUAJIT_ROLLING_VERSION
> + echo 1693350652 >$(@D)/.relver
> +endef
> +LUAJIT_POST_EXTRACT_HOOKS = LUAJIT_ROLLING_VERSION
> +HOST_LUAJIT_POST_EXTRACT_HOOKS = LUAJIT_ROLLING_VERSION
As I explained my review of your v1, the placeholder to be replaced in
the commiter UNIX time, so this is reproducible, because this does not
suffer from local settings (no timezone, no leap second...).
So, we don't need these hooks when we use the github tarball...
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-09-15 20:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 18:57 [Buildroot] [PATCH v2] package/luajit: bump to version 41fb94defa8f830ce69a8122b03f6ac3216d392a Francois Perrad
2023-09-14 20:25 ` Thomas Petazzoni via buildroot
2023-09-15 20:11 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230915201152.GA2571@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
--cc=fperrad@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox