Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Christian Stewart <christian@aperture.us>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/conmon: fix libseccomp shared build
Date: Sat, 16 Sep 2023 15:21:55 +0200	[thread overview]
Message-ID: <20230916132155.GF415981@scaer> (raw)
In-Reply-To: <20230916125132.1509289-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2023-09-16 14:51 +0200, Fabrice Fontaine spake thusly:
> Drop patch and disable libseccomp when building statically to avoid the
> following build failure raised since commit
> 29834d8a12d984e8efe05398c5aaa6a61f7880e0:
> 
> src/seccomp_notify.c: In function 'seccomp_notify_plugins_load':
> src/seccomp_notify.c:136:42: warning: implicit declaration of function 'dlopen'; did you mean 'popen'? [-Wimplicit-function-declaration]
>   136 |                 ctx->plugins[s].handle = dlopen(it, RTLD_NOW);
>       |                                          ^~~~~~
>       |                                          popen
> src/seccomp_notify.c:136:53: error: 'RTLD_NOW' undeclared (first use in this function)
>   136 |                 ctx->plugins[s].handle = dlopen(it, RTLD_NOW);
>       |                                                     ^~~~~~~~
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/13d3b46990720bba8621c922b5dce54ab650e96d
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  ...01-remove-unused-dlfcn.h-header-file.patch | 26 -------------------
>  package/conmon/conmon.mk                      |  2 +-
>  2 files changed, 1 insertion(+), 27 deletions(-)
>  delete mode 100644 package/conmon/0001-remove-unused-dlfcn.h-header-file.patch
> 
> diff --git a/package/conmon/0001-remove-unused-dlfcn.h-header-file.patch b/package/conmon/0001-remove-unused-dlfcn.h-header-file.patch
> deleted file mode 100644
> index 14f817942e..0000000000
> --- a/package/conmon/0001-remove-unused-dlfcn.h-header-file.patch
> +++ /dev/null
> @@ -1,26 +0,0 @@
> -From e28634a0e847a14c58482f962bc9b1d69937387f Mon Sep 17 00:00:00 2001
> -From: Waldemar Brodkorb <wbx@openadk.org>
> -Date: Sat, 12 Aug 2023 12:53:37 +0200
> -Subject: [PATCH] remove unused dlfcn.h header file
> -
> -Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> -Upstream: https://github.com/containers/conmon/issues/443
> ----
> - src/seccomp_notify.c | 1 -
> - 1 file changed, 1 deletion(-)
> -
> -diff --git a/src/seccomp_notify.c b/src/seccomp_notify.c
> -index 8d34d9d..2a8371d 100644
> ---- a/src/seccomp_notify.c
> -+++ b/src/seccomp_notify.c
> -@@ -7,7 +7,6 @@
> - 
> - #include <errno.h>
> - #include <sys/ioctl.h>
> --#include <dlfcn.h>
> - #include <sys/wait.h>
> - #include <sys/mount.h>
> - #include <signal.h>
> --- 
> -2.39.2
> -
> diff --git a/package/conmon/conmon.mk b/package/conmon/conmon.mk
> index 29deb2af47..50807f8c6a 100644
> --- a/package/conmon/conmon.mk
> +++ b/package/conmon/conmon.mk
> @@ -11,7 +11,7 @@ CONMON_LICENSE_FILES = LICENSE
>  
>  CONMON_DEPENDENCIES = host-pkgconf libglib2
>  
> -ifeq ($(BR2_PACKAGE_LIBSECCOMP),y)
> +ifeq ($(BR2_PACKAGE_LIBSECCOMP):$(BR2_STATIC_LIBS),y:)
>  CONMON_DISABLE_SECCOMP = 0
>  CONMON_DEPENDENCIES += libseccomp
>  else
> -- 
> 2.40.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-09-16 13:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-16 12:51 [Buildroot] [PATCH 1/1] package/conmon: fix libseccomp shared build Fabrice Fontaine
2023-09-16 13:21 ` Yann E. MORIN [this message]
2023-09-24 21:15 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230916132155.GF415981@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=christian@aperture.us \
    --cc=fontaine.fabrice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox