From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/util-linux: fix build with uclibc-ng < 1.0.42
Date: Wed, 20 Sep 2023 22:20:44 +0200 [thread overview]
Message-ID: <20230920222044.2cebba47@windsurf> (raw)
In-Reply-To: <20230918203711.2650666-1-fontaine.fabrice@gmail.com>
On Mon, 18 Sep 2023 22:37:11 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk
> index 73eda5c171..72126adb00 100644
> --- a/package/util-linux/util-linux.mk
> +++ b/package/util-linux/util-linux.mk
> @@ -96,6 +96,9 @@ endif
> UTIL_LINUX_CONF_OPTS += --without-ncursesw --without-ncurses
> endif
>
> +# workaround for static_assert on uclibc-ng < 1.0.42
> +UTIL_LINUX_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -Dstatic_assert=_Static_assert"
This should have been UTIL_LINUX_LIBS_CONF_ENV. make check-package is
smart enough to detect this:
WARNING: package/util-linux/util-linux-libs/util-linux-libs.mk:56: possible typo: UTIL_LINUX_CONF_ENV -> *UTIL_LINUX_LIBS*
I fixed that when applying.
However, overall, I think we should probably stop using those older
toolchains. Practically speaking for uClibc, we only support a
reasonably recent uClibc variant in Buildroot.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-09-20 20:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 20:37 [Buildroot] [PATCH 1/1] package/util-linux: fix build with uclibc-ng < 1.0.42 Fabrice Fontaine
2023-09-20 20:20 ` Thomas Petazzoni via buildroot [this message]
2023-09-25 11:45 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230920222044.2cebba47@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox