From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/esp-hosted: fix build failure on s390x
Date: Thu, 21 Sep 2023 20:58:20 +0200 [thread overview]
Message-ID: <20230921185820.GL512384@scaer> (raw)
In-Reply-To: <20230921111016.1041614-1-giulio.benetti@benettiengineering.com>
guilio, All,
On 2023-09-21 13:10 +0200, Giulio Benetti spake thusly:
> s390x doesn't support Wi-Fi on Linux so let's disable the package for such
> architecture.
So, your tile is wrong: it is not *fixing* a build failure of the package;
it excludes it for s390x.
But too late, it's already applied..
Regards,
Yann E. MORIN.
> Fixes:
> http://autobuild.buildroot.net/results/f52e8a14330ff281a7096baa47f387f8c1859345
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/esp-hosted/Config.in | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/package/esp-hosted/Config.in b/package/esp-hosted/Config.in
> index 43c802fa44..42e1afa8c5 100644
> --- a/package/esp-hosted/Config.in
> +++ b/package/esp-hosted/Config.in
> @@ -1,8 +1,10 @@
> comment "esp-hosted needs a Linux kernel to be built"
> + depends on !BR2_s390x
> depends on !BR2_LINUX_KERNEL
>
> config BR2_PACKAGE_ESP_HOSTED
> bool "esp-hosted"
> + depends on !BR2_s390x
> depends on BR2_LINUX_KERNEL
> help
> This package builds and installs the Linux kernel driver for
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-09-21 18:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 11:10 [Buildroot] [PATCH] package/esp-hosted: fix build failure on s390x Giulio Benetti
2023-09-21 18:25 ` Arnout Vandecappelle via buildroot
2023-09-21 18:58 ` Yann E. MORIN [this message]
2023-09-25 13:48 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230921185820.GL512384@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox