From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Jens Maus <mail@jens-maus.de>
Cc: Bernd Kuhls <bernd@kuhls.net>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] package/nut: package/nut: specify --with-user/group when building NUT
Date: Sat, 23 Sep 2023 22:31:18 +0200 [thread overview]
Message-ID: <20230923203118.GE1469982@scaer> (raw)
In-Reply-To: <20230923165214.4014466-1-mail@jens-maus.de>
Jens, All,
On 2023-09-23 18:52 +0200, Jens Maus via buildroot spake thusly:
> This commit fixes a problem where the NUT package couldn't be
> used as a NUT server due to the fact that the default group for
> nobody is "nogroup" and not "nobody" like the internal default
> of NUT. Thus, when starting a NUT server daemon the daemon starts
> with incorrect group permissions. This commit fixes this
> shortcoming by introducing a dedicated 'nut' user and 'nut' group
> to drop priviledges to it.
>
> Signed-off-by: Jens Maus <mail@jens-maus.de>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> Changes v1 -> v2:
> - added NUT_USERS with nut/nut user and group (Yann)
>
> Signed-off-by: Jens Maus <mail@jens-maus.de>
> ---
> package/nut/nut.mk | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/package/nut/nut.mk b/package/nut/nut.mk
> index fb98ba04f0..4c322aeb85 100644
> --- a/package/nut/nut.mk
> +++ b/package/nut/nut.mk
> @@ -24,7 +24,9 @@ NUT_POST_PATCH_HOOKS += NUT_FIX_CONFIGURE
> NUT_CONF_OPTS = \
> --with-altpidpath=/var/run/upsd \
> --with-dev \
> - --without-doc
> + --without-doc \
> + --with-user=nut \
> + --with-group=nut
>
> NUT_CONF_ENV = \
> ax_cv_check_cflags__Werror__Wno_unknown_warning_option=no \
> @@ -34,6 +36,10 @@ NUT_CONF_ENV = \
> ac_cv_func_strncasecmp=yes \
> ax_cv__printf_string_null=yes
>
> +define NUT_USERS
> + nut -1 nut -1 * - - - NUT user
> +endef
> +
> ifeq ($(call qstrip,$(BR2_PACKAGE_NUT_DRIVERS)),)
> NUT_CONF_OPTS += --with-drivers=auto
> else
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-09-23 20:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 15:35 [Buildroot] [PATCH 2/2] package/nut: specify --with-user/group when building NUT Jens Maus
2017-06-08 19:20 ` Yann E. MORIN
2017-06-10 7:04 ` Jens Maus
2017-06-10 7:21 ` Yann E. MORIN
2023-09-23 16:52 ` [Buildroot] [PATCH v2] package/nut: " Jens Maus via buildroot
2023-09-23 20:31 ` Yann E. MORIN [this message]
2023-09-26 8:02 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230923203118.GE1469982@scaer \
--to=yann.morin.1998@free.fr \
--cc=bernd@kuhls.net \
--cc=buildroot@buildroot.org \
--cc=mail@jens-maus.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox