Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Marcus Folkesson <marcus.folkesson@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libostree: needs headers >= 5.4
Date: Sun, 24 Sep 2023 12:34:10 +0200	[thread overview]
Message-ID: <20230924103410.GI1469982@scaer> (raw)
In-Reply-To: <20230923203359.16430-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2023-09-23 22:33 +0200, Fabrice Fontaine spake thusly:
> linux/fsverity.h is only available since kernel 5.4 and
> https://github.com/torvalds/linux/commit/085771ec14b9bdb843fe9283d4703ced395d1b0b
> resulting in the following build failure since bump to version 2023.5 in
> commit c64a3e9767757f6bab0ecf2df35871508003f39e and
> https://github.com/containers/composefs/commit/d3b4b1a2599e74757a3ada47a88645b363067a0a:
> 
> composefs/libcomposefs/lcfs-writer-erofs.c:37:10: fatal error: linux/fsverity.h: No such file or directory
>    37 | #include <linux/fsverity.h>
>       |          ^~~~~~~~~~~~~~~~~~
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/045987a09cf9061dae80db6ada1f912b2867db26
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/libostree/Config.in | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/package/libostree/Config.in b/package/libostree/Config.in
> index 696e8e1d6c..9c59413eb1 100644
> --- a/package/libostree/Config.in
> +++ b/package/libostree/Config.in
> @@ -6,6 +6,7 @@ config BR2_PACKAGE_LIBOSTREE
>  	depends on BR2_USE_MMU # e2fsprogs, libglib2, libgpgme
>  	# doesn't build with musl due to lack of TEMP_FAILURE_RETRY()
>  	depends on !BR2_TOOLCHAIN_USES_MUSL
> +	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_4 # linux/fsverity.h
>  	select BR2_PACKAGE_E2FSPROGS
>  	select BR2_PACKAGE_LIBARCHIVE if BR2_s390x
>  	select BR2_PACKAGE_LIBGLIB2
> @@ -18,8 +19,9 @@ config BR2_PACKAGE_LIBOSTREE
>  
>  	  https://ostree.readthedocs.io/en/latest/
>  
> -comment "libostree needs a uClibc or glibc toolchain w/ threads, dynamic library, wchar"
> +comment "libostree needs a uClibc or glibc toolchain w/ threads, dynamic library, wchar, headers >= 5.4"
>  	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS \
> -		|| !BR2_USE_WCHAR || BR2_TOOLCHAIN_USES_MUSL
> +		|| !BR2_USE_WCHAR || BR2_TOOLCHAIN_USES_MUSL || \
> +		!BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_4
>  	depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS
>  	depends on BR2_USE_MMU
> -- 
> 2.40.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2023-09-24 10:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-23 20:33 [Buildroot] [PATCH 1/1] package/libostree: needs headers >= 5.4 Fabrice Fontaine
2023-09-24 10:34 ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230924103410.GI1469982@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=marcus.folkesson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox