From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: TIAN Yuanhao <tianyuanhao3@163.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/open-iscsi: fix musl build
Date: Sat, 30 Sep 2023 16:08:31 +0200 [thread overview]
Message-ID: <20230930160831.11292fee@windsurf> (raw)
In-Reply-To: <20230930132822.436857-1-fontaine.fabrice@gmail.com>
On Sat, 30 Sep 2023 15:28:22 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> ++#ifndef GLOB_ONLYDIR
> ++#define GLOB_ONLYDIR 0x100
> ++#endif
But musl doesn't support this flag, so isn't that wrong? musl will most
likely ignore it. What is the impact on the application if the glob
also matches files, not just directories? Perhaps it breaks the
application behavior. Are you sure we can just blindly do this
workaround?
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-09-30 14:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-30 13:28 [Buildroot] [PATCH 1/1] package/open-iscsi: fix musl build Fabrice Fontaine
2023-09-30 14:08 ` Thomas Petazzoni via buildroot [this message]
2023-10-02 15:07 ` Fabrice Fontaine
2023-11-04 22:08 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230930160831.11292fee@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tianyuanhao3@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox