From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Charles Hardin <ckhardin@gmail.com>
Cc: Sergey Bobrenok <bobrofon@gmail.com>,
Samuel Martin <s.martin49@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/sdbus-cpp: add support to build the host stub generator
Date: Sat, 30 Sep 2023 16:13:59 +0200 [thread overview]
Message-ID: <20230930161359.21efa1af@windsurf> (raw)
In-Reply-To: <20230620174321.4774-1-ckhardin@gmail.com>
Hello Charles,
On Tue, 20 Jun 2023 10:43:21 -0700
Charles Hardin <ckhardin@gmail.com> wrote:
> Add a host option to build the xml2cpp-codegen part of the
> sdbus-cpp package for use in creating adaptor and proxy
> implementations from the D-Bus IDL.
>
> Signed-off-by: Charles Hardin <ckhardin@gmail.com>
I've applied, with some small changes, see below.
> diff --git a/package/sdbus-cpp/Config.in.host b/package/sdbus-cpp/Config.in.host
> new file mode 100644
> index 0000000000..79402af441
> --- /dev/null
> +++ b/package/sdbus-cpp/Config.in.host
> @@ -0,0 +1,14 @@
> +config BR2_PACKAGE_HOST_SDBUS_CPP
> + bool "host-sdbus-c++-xml2cpp"
Changed to:
bool "host sdbus-c++"
> + depends on BR2_INSTALL_LIBSTDCPP
Not relevant, as we are a host package, while BR2_INSTALL_LIBSTDCPP
indicates availability of C++ support in the cross-compiler.
> + depends on BR2_PACKAGE_HOST_SYSTEMD
Not needed for host packages.
> + select BR2_PACKAGE_HOST_PKGCONF
Same.
> diff --git a/package/sdbus-cpp/sdbus-cpp.mk b/package/sdbus-cpp/sdbus-cpp.mk
> index 0e8d74cfcd..ece18126ba 100644
> --- a/package/sdbus-cpp/sdbus-cpp.mk
> +++ b/package/sdbus-cpp/sdbus-cpp.mk
> @@ -12,4 +12,13 @@ SDBUS_CPP_DEPENDENCIES = host-pkgconf systemd
> SDBUS_CPP_LICENSE = LGPL-2.1+ with exception (headers)
> SDBUS_CPP_LICENSE_FILES = COPYING COPYING-LGPL-Exception
>
> +# Host build for sdbus-c++-xml2cpp
> +HOST_SDBUS_CPP_DEPENDENCIES = host-pkgconf host-systemd
It's pretty silly that host-systemd is needed, because in fact the host
sdbus-c++-xml2cpp is not linked against the sdbus-c++ library, and only
the sdbus-c++ library needs libsystemd. But oh well, since anyway
systemd+host-systemd are built for target sdbus-c++, there's in
practice no overhead.
> +HOST_SDBUS_CPP_CONF_OPTS += \
^^ Changed to just =
Applied with those changes, thanks a lot!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-09-30 14:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 17:43 [Buildroot] [PATCH 1/1] package/sdbus-cpp: add support to build the host stub generator Charles Hardin
2023-06-20 20:04 ` Sergey Bobrenok
2023-09-30 14:13 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230930161359.21efa1af@windsurf \
--to=buildroot@buildroot.org \
--cc=bobrofon@gmail.com \
--cc=ckhardin@gmail.com \
--cc=s.martin49@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox