From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Brandon Maier via buildroot <buildroot@buildroot.org>
Cc: Maeva Manuel <maeva.manuel@oss.nxp.com>,
Gilles Talis <gilles.talis@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Stephane Viau <stephane.viau@oss.nxp.com>,
Brandon Maier <brandon.maier@collins.com>
Subject: Re: [Buildroot] [PATCH 3/4] package/qoriq-fm-ucode: add package for QorIQ FMan microcode
Date: Sat, 30 Sep 2023 17:58:20 +0200 [thread overview]
Message-ID: <20230930175820.7b6b64bf@windsurf> (raw)
In-Reply-To: <20230921215633.34828-3-brandon.maier@collins.com>
On Thu, 21 Sep 2023 21:56:32 +0000
Brandon Maier via buildroot <buildroot@buildroot.org> wrote:
> This package provides firmware needed for the LS1046A-FRWY Ethernet.
>
> Signed-off-by: Brandon Maier <brandon.maier@collins.com>
Applied after doing a few changes. First, changed the commit title to
"package/qoriq-fm-ucode: new package".
> diff --git a/package/qoriq-fm-ucode/Config.in b/package/qoriq-fm-ucode/Config.in
> new file mode 100644
> index 0000000000..224e7fde32
> --- /dev/null
> +++ b/package/qoriq-fm-ucode/Config.in
> @@ -0,0 +1,21 @@
> +config BR2_PACKAGE_QORIQ_FM_UCODE
> + bool "qoriq-fm-ucode"
> + help
> + These are the microcode families of the Frame Manager hardware
> + block in QorIQ products. Specific platforms require specific
> + binaries, and those also have to further match specific
> + software versions (Frame Manager Driver -- FMD).
> +
> + https://github.com/nxp-qoriq/qoriq-fm-ucode
> +
> +if BR2_PACKAGE_QORIQ_FM_UCODE
> +
> +config BR2_PACKAGE_QORIQ_FM_UCODE_PLATFORM
> + string "Platform"
Added a:
default "ls1046"
just to make sure that our autobuilders that generate random
configurations will have a valid configuration by default.
> +QORIQ_FM_UCODE_VERSION = LSDK-21.08
> +QORIQ_FM_UCODE_SITE = $(call github,nxp-qoriq,qoriq-fm-ucode,$(QORIQ_FM_UCODE_VERSION))
> +QORIQ_FM_UCODE_LICENSE = NXP Binary EULA
> +QORIQ_FM_UCODE_LICENSE_FILES = NXP-Binary-EULA.txt
> +QORIQ_FM_UCODE_REDISTRIBUTE = NO
This was not correct: this package *is* redistributable.
> +QORIQ_FM_UCODE_INSTALL_IMAGES = YES
> +QORIQ_FM_UCODE_INSTALL_TARGET = NO
> +
> +define QORIQ_FM_UCODE_INSTALL_IMAGES_CMDS
> + cp $(@D)/fsl_fman_ucode_$(BR2_PACKAGE_QORIQ_FM_UCODE_PLATFORM)*.bin \
Modified a bit to qstrip the $(BR2_PACKAGE_QORIQ_FM_UCODE_PLATFORM)
variable.
As said above: applied with those changes. Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-09-30 15:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 21:56 [Buildroot] [PATCH 1/4] board/freescale: fix arm-trusted-firmware for binutils 2.39+ Brandon Maier via buildroot
2023-09-21 21:56 ` [Buildroot] [PATCH 2/4] board/freescale: fix imx arm-trusted-firmware for GCC12 Brandon Maier via buildroot
2023-09-30 15:20 ` Thomas Petazzoni via buildroot
2023-10-13 6:03 ` Peter Korsgaard
2023-09-21 21:56 ` [Buildroot] [PATCH 3/4] package/qoriq-fm-ucode: add package for QorIQ FMan microcode Brandon Maier via buildroot
2023-09-30 15:58 ` Thomas Petazzoni via buildroot [this message]
2023-09-21 21:56 ` [Buildroot] [PATCH 4/4] configs/ls1046a-frwy: new defconfig Brandon Maier via buildroot
2023-09-30 15:58 ` Thomas Petazzoni via buildroot
2023-09-30 14:23 ` [Buildroot] [PATCH 1/4] board/freescale: fix arm-trusted-firmware for binutils 2.39+ Romain Naour
2023-09-30 15:20 ` Thomas Petazzoni via buildroot
2023-10-02 16:21 ` [Buildroot] [External] " Maier, Brandon L Collins via buildroot
2023-10-04 21:58 ` Thomas Petazzoni via buildroot
2023-10-13 6:03 ` [Buildroot] " Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230930175820.7b6b64bf@windsurf \
--to=buildroot@buildroot.org \
--cc=brandon.maier@collins.com \
--cc=festevam@gmail.com \
--cc=gilles.talis@gmail.com \
--cc=maeva.manuel@oss.nxp.com \
--cc=stephane.viau@oss.nxp.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox