Re: [Buildroot] [PATCH] package/itstool: new host package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

Thanks also for this patch. See below some comments.

On Sun,  1 Oct 2023 04:14:54 +0900
Takumi Takahashi <takumiiinn@gmail.com> wrote:

> Translate XML with PO files using W3C Internationalization Tag Set rules

We need your Signed-off-by: line here.

Also, it would be useful to have some details in the commit log on the
why it makes sense to have this package as a host package, like how it
gets used by you.

> ---
>  package/itstool/itstool.hash |  4 ++++
>  package/itstool/itstool.mk   | 15 +++++++++++++++
>  2 files changed, 19 insertions(+)

Please add an entry in the DEVELOPERS file for this package.

As it seems to be a "user-facing" tool, it probably needs a
Config.in.host file, included from package/Config.in.host.

> +ITSTOOL_VERSION = 2.0.7
> +ITSTOOL_SITE = $(call github,itstool,itstool,$(ITSTOOL_VERSION))
> +ITSTOOL_LICENSE = GPL-3.0+
> +ITSTOOL_LICENSE_FILES = COPYING COPYING.GPL3

> +HOST_ITSTOOL_DEPENDENCIES = host-python3 host-libxml2

I don't think host-libxml2 is going to be sufficient here, as we don't
build the Python bindings:

HOST_LIBXML2_CONF_OPTS = --without-zlib --without-lzma --without-python

So it looks like a new option in package/libxml2/Config.in.host would
be needed, to request building the Python bindings.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot