Re: [Buildroot] [PATCH 2/2] package/pkg-utils: teach per-package-rsync to copy or hardlink dest

[Herve Codina via buildroot <buildroot@buildroot.org>]

Yann, All,

On Wed, 18 Oct 2023 17:20:47 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> Hervé, All
> 
[...]
> 
> > > --- a/package/pkg-utils.mk
> > > +++ b/package/pkg-utils.mk
> > > @@ -214,10 +214,19 @@ ifeq ($(BR2_PER_PACKAGE_DIRECTORIES),y)
> > >  # $1: space-separated list of packages to rsync from
> > >  # $2: 'host' or 'target'
> > >  # $3: destination directory
> > > +# $4: literal "copy" or "hardlink" to copy or hardlink files from src to dest
> > >  define per-package-rsync
> > >  	mkdir -p $(3)
> > >  	$(foreach pkg,$(1),\
> > > -		rsync -a --link-dest=$(PER_PACKAGE_DIR)/$(pkg)/$(2)/ \
> > > +		rsync -a \
> > > +			--hard-links \  
> > You preserve hard links (--hard-links) in all cases (copy and hardlink).
> > In case of copy, is it correct to preserve hard links ?  
> 
> Yes, --hard-links is:
> 
>     This tells rsync to look for hard-linked files in the source and
>     link together the corresponding files on the destination.

In case of 'copy', you keep hard-links already present in source and so the
destination (final host/target dirs) is not a full copy.
Some hard-links can be present and post-build scripts can still corrupt some
per-package sources.

I don't understand why keeping hard-links on this last copy is needed and I
probably miss something...

Regards,
Hervé

> 
> Regards,
> Yann E. MORIN.
> 
> > > +			$(if $(filter hardlink,$(4)), \
> > > +				--link-dest=$(PER_PACKAGE_DIR)/$(pkg)/$(2)/, \
> > > +				$(if $(filter copy,$(4)), \
> > > +					$(empty), \
> > > +					$(error per-package-rsync can only "copy" or "hardlink", not "$(4)") \
> > > +				) \
> > > +			) \
> > >  			$(PER_PACKAGE_DIR)/$(pkg)/$(2)/ \
> > >  			$(3)$(sep))
> > >  endef  
> > 
> > [...]
> > 
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot