Re: [Buildroot] [PATCH v4 04/10] toolchain/toolchain-bare-metal: new toolchain

[Luca Ceresoli via buildroot <buildroot@buildroot.org>]

Hi Neal,

On Wed, 18 Oct 2023 12:46:40 +0000
"Frager, Neal" <neal.frager@amd.com> wrote:

> Hi Luca,
> 
> > This patch adds a new virtual package for adding a bare-metal 
> > toolchain to buildroot.  By default, this package will configure a 
> > bare-metal toolchain for the Xilinx microblaze little endian 
> > architecture.  When configured for the Xilinx microblaze architecture, 
> > this toolchain can be used to build the microblaze firmware applications for zynqmp and versal.
> > 
> > Signed-off-by: Ibai Erkiaga-Elorza <ibai.erkiaga-elorza@amd.com>
> > Signed-off-by: Neal Frager <neal.frager@amd.com>
> > ---
> > V1->V2:
> >  - adds select option to bring in all packages needed for 
> > toolchain-bare-metal
> > V2->V3:
> >  - no changes
> > V3->V4:
> >  - moved from package to toolchain directory
> >  - improved menuconfig help comment
> > ---
> >  DEVELOPERS                                    |  2 ++
> >  toolchain/Config.in                           |  1 +
> >  toolchain/toolchain-bare-metal/Config.in      | 21 +++++++++++++++++++
> >  .../toolchain-bare-metal.mk                   |  7 +++++++  
> 
> > I wonder whether this should be in
> > toolchain/toolchain-bare-metal-toolchain to make room for a future toolchain/toolchain-bare-metal-external.  
> 
> What is the value of adding another toolchain in the name?
> 
> For example:
> 
> Internal Toolchains:
> toolchain-bare-metal
> toolchain-buildroot
> 
> External Toolchains:
> toolchain-bare-metal-external
> toolchain-external
> 
> If anything, I could argue that we should then rename 'toolchain-external' to 'toolchain-buildroot-external'.
> 
> That would give us the following:
> 
> Internal Toolchains:
> toolchain-bare-metal
> toolchain-buildroot
> 
> External Toolchains:
> toolchain-bare-metal-external
> toolchain-buildroot-external
> 
> What do you think?

My understanding of the current naming is that the "buildroot" suffix
means "built by Buildroot as part of the build" while "external" means
"already built, by whatever tool". Ans as such the toolchains are
currently named toolchain-{buildroot,external}.

Following this line of thought, the bare-metal toolchains would be
called toolchain-bare-metal-{buildroot,external}.

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot