Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Francois Perrad <fperrad@gmail.com>
Cc: buildroot@busybox.net
Subject: Re: [Buildroot] [PATCH 1/2] package/perl-net-ssh2: bump to version 0.73
Date: Sun, 22 Oct 2023 16:22:20 +0200	[thread overview]
Message-ID: <20231022142220.GM2607@scaer> (raw)
In-Reply-To: <20231022140802.GJ2607@scaer>

François, All,

On 2023-10-22 16:08 +0200, Yann E. MORIN spake thusly:
> On 2023-10-20 18:19 +0200, Francois Perrad spake thusly:
> > diff README.pod:
> > see https://metacpan.org/release/RKITOVER/Net-SSH2-0.73/diff/SALVA/Net-SSH2-0.72#README.pod
> We want to have a summary of the changes directly in our commit log,
> because our commit log is all that is guarantedd to be available in
> our repository. Any reference to a thord-party location will not have
> the same guarantee (e.g. even if CPAN has existed for ages, they may
> rewrite the URLs in the future).

I should maybe explain why we need such a summary in the commit log:
README.pod is used a license file, so it is our reference as to what the
licensing terms are.

Updating the hash of the license files means the file has changed, and
that's nice that you noticed and updated.

But what we really need to know if the reason for the update, even if it
is just "typoes and rewrapping", so that it is *obvious* that there is
no licensing change.

(patch marked as "changes requested" in patchwork.)

Regards,
Yann E. MORIN.

> Incidentally, the 'diff' above confuses Patchwork:
>     https://patchwork.ozlabs.org/project/buildroot/patch/20231020161902.48876-1-francois.perrad@gadz.org/
> 
> Also, it sould be nice to explain why we have to change to another
> "author" as the origin.
> 
> Regards,
> Yann E. MORIN.
> 
> > Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> > ---
> >  package/perl-net-ssh2/perl-net-ssh2.hash | 8 ++++----
> >  package/perl-net-ssh2/perl-net-ssh2.mk   | 4 ++--
> >  2 files changed, 6 insertions(+), 6 deletions(-)
> > 
> > diff --git a/package/perl-net-ssh2/perl-net-ssh2.hash b/package/perl-net-ssh2/perl-net-ssh2.hash
> > index b2e8b2d48..91bbdc2e8 100644
> > --- a/package/perl-net-ssh2/perl-net-ssh2.hash
> > +++ b/package/perl-net-ssh2/perl-net-ssh2.hash
> > @@ -1,6 +1,6 @@
> > -# retrieved by scancpan from http://cpan.metacpan.org/
> > -md5  57aa0f6e2be4020f75888a7195ad5cba  Net-SSH2-0.72.tar.gz
> > -sha256  867d83070fac6436b9f0971918243002072fbf8d2724a87c254b34250dce0222  Net-SSH2-0.72.tar.gz
> > +# retrieved by scancpan from https://cpan.metacpan.org/
> > +md5  222625c91affcceb43e861063d52943f  Net-SSH2-0.73.tar.gz
> > +sha256  a51e4c3168fc3d8ab89a6b673c836323303e95b18de19813ec4528810ec23785  Net-SSH2-0.73.tar.gz
> >  
> >  # computed by scancpan
> > -sha256  268afaee7aa88a41959c93cd91853e8124bdbe64a74480d36ff1130e01a1c0ca  README.pod
> > +sha256  e517e8d3690bbebf97f78c5ced4f0ecb26106eef381687dd6fb3879aa5a3f031  README.pod
> > diff --git a/package/perl-net-ssh2/perl-net-ssh2.mk b/package/perl-net-ssh2/perl-net-ssh2.mk
> > index 20e45b628..91c08458e 100644
> > --- a/package/perl-net-ssh2/perl-net-ssh2.mk
> > +++ b/package/perl-net-ssh2/perl-net-ssh2.mk
> > @@ -4,9 +4,9 @@
> >  #
> >  ################################################################################
> >  
> > -PERL_NET_SSH2_VERSION = 0.72
> > +PERL_NET_SSH2_VERSION = 0.73
> >  PERL_NET_SSH2_SOURCE = Net-SSH2-$(PERL_NET_SSH2_VERSION).tar.gz
> > -PERL_NET_SSH2_SITE = $(BR2_CPAN_MIRROR)/authors/id/S/SA/SALVA
> > +PERL_NET_SSH2_SITE = $(BR2_CPAN_MIRROR)/authors/id/R/RK/RKITOVER
> >  PERL_NET_SSH2_LICENSE = Artistic or GPL-1.0+
> >  PERL_NET_SSH2_LICENSE_FILES = README.pod
> >  PERL_NET_SSH2_DEPENDENCIES = libssh2 zlib
> > -- 
> > 2.39.2
> > 
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
> 
> -- 
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2023-10-22 14:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-20 16:19 [Buildroot] [PATCH 1/2] package/perl-net-ssh2: bump to version 0.73 Francois Perrad
2023-10-20 16:19 ` [Buildroot] [PATCH 2/2] package/perl-mojolicious: bump to version 9.34 Francois Perrad
2023-10-22 14:10   ` Yann E. MORIN
2023-10-22 14:08 ` [Buildroot] [PATCH 1/2] package/perl-net-ssh2: bump to version 0.73 Yann E. MORIN
2023-10-22 14:22   ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231022142220.GM2607@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    --cc=fperrad@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox