From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Sergey Bobrenok <bobrofon@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/sdbus-cpp: remove redundant SDBUS_CPP_SOURCE variable
Date: Sun, 29 Oct 2023 12:07:19 +0100 [thread overview]
Message-ID: <20231029110719.GU687180@scaer> (raw)
In-Reply-To: <20231029101125.34481-1-bobrofon@gmail.com>
Sergey, All,
On 2023-10-29 13:11 +0300, Sergey Bobrenok spake thusly:
> There is no need to define SDBUS_CPP_SOURCE explicitly because the
> github helper defines this variable internally (but uses a different
> file name).
The _SOURCE value is not set by the github helper, but the github helper
works equally well with the default _SOURCE value. In fact, the github
URLs do not care what the final component of the URL is, as it is not
used bu github to decide what to archvie.
Applied to master with the commit log slightly amended, thanks.
Regards,
Yann E. MORIN.
> Signed-off-by: Sergey Bobrenok <bobrofon@gmail.com>
> ---
> package/sdbus-cpp/sdbus-cpp.hash | 2 +-
> package/sdbus-cpp/sdbus-cpp.mk | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/package/sdbus-cpp/sdbus-cpp.hash b/package/sdbus-cpp/sdbus-cpp.hash
> index 379864e3ba..f4336228af 100644
> --- a/package/sdbus-cpp/sdbus-cpp.hash
> +++ b/package/sdbus-cpp/sdbus-cpp.hash
> @@ -1,4 +1,4 @@
> # Locally computed:
> -sha256 ca7405c7f0f9ae3023dcfa37bc68974c4b8a1c9ea2909b970e0aedc3e8657ee6 v1.4.0.tar.gz
> +sha256 ca7405c7f0f9ae3023dcfa37bc68974c4b8a1c9ea2909b970e0aedc3e8657ee6 sdbus-cpp-1.4.0.tar.gz
> sha256 20c17d8b8c48a600800dfd14f95d5cb9ff47066a9641ddeab48dc54aec96e331 COPYING
> sha256 a1c9e75e25d8f2ce18017c88978edab2f0dbc7814ad0697d4ff2e5e59959f657 COPYING-LGPL-Exception
> diff --git a/package/sdbus-cpp/sdbus-cpp.mk b/package/sdbus-cpp/sdbus-cpp.mk
> index 2c3844094e..9ffaeb26d2 100644
> --- a/package/sdbus-cpp/sdbus-cpp.mk
> +++ b/package/sdbus-cpp/sdbus-cpp.mk
> @@ -5,7 +5,6 @@
> ################################################################################
>
> SDBUS_CPP_VERSION = 1.4.0
> -SDBUS_CPP_SOURCE = v$(SDBUS_CPP_VERSION).tar.gz
> SDBUS_CPP_SITE = $(call github,Kistler-Group,sdbus-cpp,v$(SDBUS_CPP_VERSION))
> SDBUS_CPP_INSTALL_STAGING = YES
> SDBUS_CPP_DEPENDENCIES = host-pkgconf systemd
> --
> 2.41.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-10-29 11:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 20:11 [Buildroot] [PATCH 1/1] package/sdbus-cpp: bump to version 1.4.0 Sergey Bobrenok
2023-10-29 8:43 ` Yann E. MORIN
2023-10-29 8:45 ` Yann E. MORIN
2023-10-29 10:11 ` [Buildroot] [PATCH 1/1] package/sdbus-cpp: remove redundant SDBUS_CPP_SOURCE variable Sergey Bobrenok
2023-10-29 11:07 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231029110719.GU687180@scaer \
--to=yann.morin.1998@free.fr \
--cc=bobrofon@gmail.com \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox