From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: TIAN Yuanhao <tianyuanhao3@163.com>
Cc: Christian Stewart <christian@paral.in>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/tini: move docker-init to /usr/libexec/docker/
Date: Tue, 31 Oct 2023 21:42:50 +0100 [thread overview]
Message-ID: <20231031204250.GA2568@scaer> (raw)
In-Reply-To: <20231031155029.2689-1-tianyuanhao3@163.com>
Yuanhao, All,
On 2023-10-31 15:50 +0000, TIAN Yuanhao spake thusly:
> The docker-init is not intended to be a user-facing command, and as such
> it is more appropriate for it to be found in /usr/libexec/ than in $PATH.
>
> See:
> https://github.com/moby/moby/commit/6caaa8cadc9e4f1e122b7b2bb4451500bbec6086
> https://github.com/docker/docker-ce-packaging/commit/5a998af6f53d978810aa6f5b566a484911ff4ca2
>
> Signed-off-by: TIAN Yuanhao <tianyuanhao3@163.com>
> ---
> package/tini/tini.mk | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/tini/tini.mk b/package/tini/tini.mk
> index 9da54f8a25..75b6786cfb 100644
> --- a/package/tini/tini.mk
> +++ b/package/tini/tini.mk
> @@ -31,7 +31,8 @@ endef
>
> define TINI_INSTALL_TARGET_CMDS
> $(INSTALL) -D -m 0755 $(@D)/bin/tini $(TARGET_DIR)/usr/bin/tini
> - ln -sf tini $(TARGET_DIR)/usr/bin/docker-init
> + $(INSTALL) -d -m 0755 $(TARGET_DIR)/usr/libexec/docker
Although what you did is correct, we usually use plain mkdir -p to
create directories, so I've changed that.
Applied to master, thanks.
Regards,
Yann E. MORIN.
> + ln -sf ../../bin/tini $(TARGET_DIR)/usr/libexec/docker/docker-init
> endef
>
> # Tini's CMakeLists.txt is not suitable for Buildroot.
> --
> 2.34.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-10-31 20:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 15:50 [Buildroot] [PATCH 1/1] package/tini: move docker-init to /usr/libexec/docker/ TIAN Yuanhao
2023-10-31 20:42 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231031204250.GA2568@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=christian@paral.in \
--cc=tianyuanhao3@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox