From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Adam Duskett <adam.duskett@amarulasolutions.com>
Cc: Maxim Kochetkov <fido_max@inbox.ru>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] support/testing/tests/package/test_postgresql.py: new test
Date: Wed, 1 Nov 2023 17:43:34 +0100 [thread overview]
Message-ID: <20231101174334.2b6a1e77@windsurf> (raw)
In-Reply-To: <20231010164554.2954023-2-adam.duskett@amarulasolutions.com>
Hello,
On Tue, 10 Oct 2023 18:45:54 +0200
Adam Duskett <adam.duskett@amarulasolutions.com> wrote:
> +class TestPostgreSQLInitd(infra.basetest.BRTest):
Initd is not a very good name. To me Initd doesn't mean
"Sysvinit/Busybox init".
I see the polkit tests already use that naming, though.
> + config: str = """
Any reason to use this syntax? I don't have anything against it, but
it's not consistent with how we define the configuration in other test
cases, and I like consistency.
> + BR2_arm=y
> + BR2_cortex_a9=y
> + BR2_ARM_ENABLE_VFP=y
> + BR2_TOOLCHAIN_EXTERNAL=y
> + BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
Any reason not to use BASIC_TOOLCHAIN_CONFIG instead?
> + BR2_PER_PACKAGE_DIRECTORIES=y
Not needed.
> + BR2_PACKAGE_POSTGRESQL=y
> + BR2_TARGET_ROOTFS_EXT2=y
> + BR2_TARGET_ROOTFS_EXT2_4=y
> + BR2_TARGET_ROOTFS_EXT2_SIZE="128M"
> + # BR2_TARGET_ROOTFS_TAR is not set
> + """
> +
> + def test_run(self):
> + img = os.path.join(self.builddir, "images", "rootfs.ext2")
> + self.emulator.boot(
> + arch="armv7",
This would have to be changed to arvm5 if you use the
BASIC_TOOLCHAIN_CONFIG.
Long term, maybe we could consider changing the BASIC_TOOLCHAIN_CONFIG
to use ARMv7, would perhaps be more sensible than the aging ARMv5
architecture.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-11-01 16:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 16:45 [Buildroot] [PATCH 1/2] package/postgresql/postgresql.service: set locale for initdb to C Adam Duskett
2023-10-10 16:45 ` [Buildroot] [PATCH 2/2] support/testing/tests/package/test_postgresql.py: new test Adam Duskett
2023-11-01 16:43 ` Thomas Petazzoni via buildroot [this message]
2023-10-10 17:02 ` [Buildroot] [PATCH 1/2] package/postgresql/postgresql.service: set locale for initdb to C Maxim Kochetkov via buildroot
2023-11-01 16:37 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231101174334.2b6a1e77@windsurf \
--to=buildroot@buildroot.org \
--cc=adam.duskett@amarulasolutions.com \
--cc=fido_max@inbox.ru \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox