From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Christian Stewart <christian@aperture.us>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/conmon: seccomp needs headers >= 5.0
Date: Wed, 1 Nov 2023 18:50:17 +0100 [thread overview]
Message-ID: <20231101185017.53d4fbb8@windsurf> (raw)
In-Reply-To: <20231101154350.541223-1-fontaine.fabrice@gmail.com>
On Wed, 1 Nov 2023 16:43:49 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> conmon unconditionally uses seccomp_notif_sizes which is only available
> since kernel 5.0 and
> https://github.com/torvalds/linux/commit/6a21cc50f0c7f87dae5259f6cfefe024412313f6
> resulting in the following build failure since the addition of the
> package in commit 06f50ff1bf066feb6cf6ed512113773f87c884fb:
>
> In file included from src/seccomp_notify.h:4,
> from src/seccomp_notify.c:26:
> src/seccomp_notify_plugin.h:33:78: warning: 'struct seccomp_notif_sizes' declared inside parameter list will not be visible outside of this definition or declaration
> 33 | typedef int (*run_oci_seccomp_notify_handle_request_cb)(void *opaque, struct seccomp_notif_sizes *sizes, struct seccomp_notif *sreq,
> | ^~~~~~~~~~~~~~~~~~~
> src/seccomp_notify.c:47:36: error: field 'sizes' has incomplete type
> 47 | struct seccomp_notif_sizes sizes;
> | ^~~~~
>
> Fixes:
> - http://autobuild.buildroot.org/results/cbfa2f3a585b7feecd902137bc589a1ec15cbefe
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/conmon/conmon.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-11-01 17:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 15:43 [Buildroot] [PATCH 1/1] package/conmon: seccomp needs headers >= 5.0 Fabrice Fontaine
2023-11-01 17:50 ` Thomas Petazzoni via buildroot [this message]
2023-11-08 7:22 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231101185017.53d4fbb8@windsurf \
--to=buildroot@buildroot.org \
--cc=christian@aperture.us \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox