Re: [Buildroot] [PATCH 1/2] board/bananapi/bananapi-m2-berry: switch to use extlinux.conf

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Giulio,

Thanks for your work on this!

On Fri, 13 Oct 2023 23:08:40 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> diff --git a/board/bananapi/bananapi-m2-berry/genimage.cfg b/board/bananapi/bananapi-m2-berry/genimage.cfg
> index 535f3dffee..92c8677545 100644
> --- a/board/bananapi/bananapi-m2-berry/genimage.cfg
> +++ b/board/bananapi/bananapi-m2-berry/genimage.cfg
> @@ -1,15 +1,3 @@
> -image boot.vfat {
> -	vfat {
> -		files = {
> -			"zImage",
> -			"sun8i-v40-bananapi-m2-berry.dtb",
> -			"boot.scr"
> -		}
> -	}
> -
> -	size = 64M
> -}
> -
>  image sdcard.img {
>  	hdimage {
>  	}
> @@ -21,12 +9,6 @@ image sdcard.img {
>  		size = 1016K # 1MB - 8KB
>  	}
>  
> -	partition boot {
> -		partition-type = 0xC
> -		bootable = "true"
> -		image = "boot.vfat"
> -	}
> -
>  	partition rootfs {
>  		partition-type = 0x83
>  		image = "rootfs.ext4"

Are you sure this works? Indeed the FAT partition used to have the
bootable = "true" flag. Now, no partition has this flag. But from what
I remember, the heuristic that U-Boot uses to determine which partition
has the extlinux.conf file is precisely this bootable flag.

Could you double check this?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot