Re: [Buildroot] [PATCH 1/2] configs/raspberrypi: bump Linux version to 6.1.55

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Bram,

On Wed, 11 Oct 2023 18:24:29 +0200
Bram Oosterhuis <dev@bybram.com> wrote:

> Linux 6.1 has been marked LTS for a long time now. Time to bump
> Linux for RaspberryPi's to the latest 6.1.55-v7. Since April 2022
> the RaspberryPi defconfigs have compressed kernel module enabled
> by default. (see [1] and [2]).
> 
> To load compressed kernel modules kmod and xz packages are needed
> because busybox doesn't support it.
> 
> [1] https://github.com/raspberrypi/linux/commit/c45b4223a4e4a8cfe39edbb4949329ea478fa4e2
> [2] https://github.com/raspberrypi/linux/issues/4966
> 
> Signed-off-by: Bram Oosterhuis <dev@bybram.com>

Thanks for this patch. Could you clarify in the commit log on which
platforms it was runtime-tested, vs. the platforms for which you only
verified the build?

> +# Enable compressed kernel module support
> +BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
> +BR2_PACKAGE_KMOD_TOOLS
> +BR2_PACKAGE_XZ
> +BR2_PACKAGE_KMOD
> +BR2_PACKAGE_HOST_KMOD_XZ

I'm afraid this has certainly not been tested, as I believe these lines
have no effect since they lack the =y to enable the option:

BR2_PACKAGE_XZ=y

for example.

> \ No newline at end of file

Please fix this to have a newline at end of file.

(Of course, same for all other defconfigs)

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot