Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/iodine: bump to version 0.8.0
Date: Fri, 3 Nov 2023 10:33:31 +0100	[thread overview]
Message-ID: <20231103103331.4f60743e@windsurf> (raw)
In-Reply-To: <20231102222217.239293-1-fontaine.fabrice@gmail.com>

Hello Fabrice,

On Thu,  2 Nov 2023 23:22:17 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> -IODINE_VERSION = 0.7.0
> +IODINE_VERSION = 0.8.0
>  IODINE_SITE = http://code.kryo.se/iodine
>  IODINE_DEPENDENCIES = zlib

This...

>  IODINE_LICENSE = MIT
> -IODINE_LICENSE_FILES = README
> +IODINE_LICENSE_FILES = LICENSE
>  IODINE_CPE_ID_VENDOR = kryo
>  IODINE_SELINUX_MODULES = iodine
> +IODINE_DEPENDENCIES = \
> +	host-pkgconf \
> +	$(if $(BR2_PACKAGE_LIBSELINUX),libselinux) \
> +	$(if $(BR2_PACKAGE_SYSTEMD),systemd)

would be badly overridden by this.

As reported by "make check-package":

WARNING: package/iodine/iodine.mk:14: unconditional override of variable IODINE_DEPENDENCIES

I fixed that up when applying. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2023-11-03  9:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-02 22:22 [Buildroot] [PATCH 1/1] package/iodine: bump to version 0.8.0 Fabrice Fontaine
2023-11-03  9:33 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231103103331.4f60743e@windsurf \
    --to=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox