From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: David GOUARIN <dgouarin@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/freeradius-server: fix redis handling
Date: Sat, 4 Nov 2023 14:55:27 +0100 [thread overview]
Message-ID: <20231104145527.1ff6fc02@windsurf> (raw)
In-Reply-To: <20231104095448.641992-1-fontaine.fabrice@gmail.com>
Hello Fabrice,
On Sat, 4 Nov 2023 10:54:48 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> redis handling is wrong since the addition of the package in commit
> 736c4c1655d93652a9a7e79235bbe726b3d46176. Indeed, freeradius-server
> needs hiredis, not redis
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> .../freeradius-server/freeradius-server.mk | 20 ++++++++++++-------
> 1 file changed, 13 insertions(+), 7 deletions(-)
>
> diff --git a/package/freeradius-server/freeradius-server.mk b/package/freeradius-server/freeradius-server.mk
> index af3320eb44..1931c970e8 100644
> --- a/package/freeradius-server/freeradius-server.mk
> +++ b/package/freeradius-server/freeradius-server.mk
> @@ -71,6 +71,19 @@ FREERADIUS_SERVER_CONF_OPTS += \
> --without-rlm_ippool
> endif
>
> +ifeq ($(BR2_PACKAGE_HIREDIS),y)
> +FREERADIUS_SERVER_CONF_OPTS += \
> + --with-rlm_cache_redis \
Are you sure about this option? I don't see it existing.
> -ifeq ($(BR2_PACKAGE_REDIS),y)
> -FREERADIUS_SERVER_CONF_OPTS += --with-rlm_redis --with-rlm_rediswho
And it wasn't used here.
Could you clarify this?
Is this a mixup with your other patch bumping freeradius-server?
Thanks,
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-11-04 13:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-04 9:54 [Buildroot] [PATCH 1/1] package/freeradius-server: fix redis handling Fabrice Fontaine
2023-11-04 13:55 ` Thomas Petazzoni via buildroot [this message]
2023-11-04 14:06 ` Fabrice Fontaine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231104145527.1ff6fc02@windsurf \
--to=buildroot@buildroot.org \
--cc=dgouarin@gmail.com \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox