Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Brandon Maier via buildroot <buildroot@buildroot.org>
Cc: Bernd Kuhls <bernd@kuhls.net>,
	"Yann E . MORIN" <yann.morin.1998@free.fr>,
	Brandon Maier <brandon.maier@collins.com>,
	"Neal J. Buchmeyer" <neal.buchmeyer@collins.com>
Subject: Re: [Buildroot] [PATCH v2 1/2] package/wireless_tools: make 'iwconfig' tool optional
Date: Sat, 4 Nov 2023 19:17:56 +0100	[thread overview]
Message-ID: <20231104191756.02d7847b@windsurf> (raw)
In-Reply-To: <20231024184835.3911-1-brandon.maier@collins.com>

On Tue, 24 Oct 2023 18:48:34 +0000
Brandon Maier via buildroot <buildroot@buildroot.org> wrote:

> @@ -7,6 +9,12 @@ config BR2_PACKAGE_WIRELESS_TOOLS
>  
>  if BR2_PACKAGE_WIRELESS_TOOLS
>  
> +config BR2_PACKAGE_WIRELESS_TOOLS_IWCONFIG
> +	bool "Add iwconfig"

Change to:

	bool "Install tools"

because it's really about "installing", and it is more consistent with
the option for the shared library, which is "Install shared library".

I've also added:

	default y

to preserve the existing behavior.

Applied with those changes. Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2023-11-04 18:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-19 20:33 [Buildroot] [PATCH 1/1] package/wireless_tools: add option to build ifrename Brandon Maier via buildroot
2023-10-22 18:47 ` Yann E. MORIN
2023-10-24 18:52   ` Maier, Brandon L Collins via buildroot
2023-10-24 18:48 ` [Buildroot] [PATCH v2 1/2] package/wireless_tools: make 'iwconfig' tool optional Brandon Maier via buildroot
2023-10-24 18:48   ` [Buildroot] [PATCH v2 2/2] package/wireless_tools: add option to build ifrename Brandon Maier via buildroot
2023-11-04 18:18     ` Thomas Petazzoni via buildroot
2023-11-04 18:17   ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231104191756.02d7847b@windsurf \
    --to=buildroot@buildroot.org \
    --cc=bernd@kuhls.net \
    --cc=brandon.maier@collins.com \
    --cc=neal.buchmeyer@collins.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox