Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: enki <enki@fsck.pl>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>,
	Thomas Petazzoni via buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH v3 1/1] package/spirv-tools: fix build issue
Date: Mon, 6 Nov 2023 08:48:50 +0100	[thread overview]
Message-ID: <20231106084850.1d0f01ce@windsurf> (raw)
In-Reply-To: <18ba1050ead.e92a523a459223.2327298946072754198@fsck.pl>

On Sun, 05 Nov 2023 20:45:45 +0100
enki <enki@fsck.pl> wrote:

> Right, the initial patch also added a dependency on the C++ compiler. I reworked it after Yann's reply to be applied on top of the 
> already applied C++17 requirement patch. I forgot to adjust the list of Fixed: builds. 
> This should now be ok only referencing BR2_STATIC_LIBS cases.

Thanks for the feedback. Could you send an updated patch, with an
improved/update commit log?

Thanks a lot,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-11-06  7:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-27  9:15 [Buildroot] [PATCH v2 1/1] package/spirv-tools: fix build issue Maciej Grela
2023-10-28 22:13 ` Yann E. MORIN
2023-10-30 13:23 ` enki
2023-10-30 13:28   ` [Buildroot] [PATCH v3 " Maciej Grela
2023-11-04 13:35     ` Thomas Petazzoni via buildroot
2023-11-05 19:40       ` [Buildroot] [PATCH v4 " Maciej Grela
2023-11-05 19:45       ` [Buildroot] [PATCH v3 " enki
2023-11-06  7:48         ` Thomas Petazzoni via buildroot [this message]
2023-11-06 13:08           ` [Buildroot] [PATCH v4 " Maciej Grela
2023-11-06 13:30             ` Yann E. MORIN
2023-11-06 21:00               ` enki
2023-11-06 21:43                 ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231106084850.1d0f01ce@windsurf \
    --to=buildroot@buildroot.org \
    --cc=enki@fsck.pl \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox