From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Adam Duskett <adam.duskett@amarulasolutions.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/5] test_systemd_selinux.py: use timeout argument for emulator.login
Date: Mon, 6 Nov 2023 20:45:20 +0100 [thread overview]
Message-ID: <20231106204520.00ec35d1@windsurf> (raw)
In-Reply-To: <20231105215221.1602465-2-adam.duskett@amarulasolutions.com>
On Sun, 5 Nov 2023 14:52:18 -0700
Adam Duskett <adam.duskett@amarulasolutions.com> wrote:
> self.emulator.timeout_multiplier *= 10 is equivilent to 60 * 10 or 600.
>
> Signed-off-by: Adam Duskett <adam.duskett@amarulasolutions.com>
> ---
> support/testing/tests/init/test_systemd_selinux.py | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/support/testing/tests/init/test_systemd_selinux.py b/support/testing/tests/init/test_systemd_selinux.py
> index fab23e3330..d463f91669 100644
> --- a/support/testing/tests/init/test_systemd_selinux.py
> +++ b/support/testing/tests/init/test_systemd_selinux.py
> @@ -21,9 +21,8 @@ class TestSELinuxSystemd(infra.basetest.BRTest):
> """
>
> def wait_boot(self):
> - # The complete boot with systemd takes more time than what the default multipler permits
> - self.emulator.timeout_multiplier *= 10
> - self.emulator.login()
> + # The complete boot with systemd takes more time than what the default multiplier permits
I think the wording of the comment no longer made sense, since we're no
longer tweaking the multiplier. So I've reworded the comment a bit
(likewise for PATCH 3/5).
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-11-06 19:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-05 21:52 [Buildroot] [PATCH 1/5] support/testing/infra/emulator.py: add a timeout argument for the login method Adam Duskett
2023-11-05 21:52 ` [Buildroot] [PATCH 2/5] test_systemd_selinux.py: use timeout argument for emulator.login Adam Duskett
2023-11-06 19:45 ` Thomas Petazzoni via buildroot [this message]
2023-11-10 11:51 ` Peter Korsgaard
2023-11-05 21:52 ` [Buildroot] [PATCH 3/5] test_lxc.py: " Adam Duskett
2023-11-10 11:51 ` Peter Korsgaard
2023-11-05 21:52 ` [Buildroot] [PATCH 4/5] test_python_django.py: fix timeout calculation Adam Duskett
2023-11-10 11:51 ` Peter Korsgaard
2023-11-05 21:52 ` [Buildroot] [PATCH 5/5] support/testing/tests/package/test_firewalld.py: new test Adam Duskett
2023-11-06 19:44 ` [Buildroot] [PATCH 1/5] support/testing/infra/emulator.py: add a timeout argument for the login method Thomas Petazzoni via buildroot
2023-11-10 11:51 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231106204520.00ec35d1@windsurf \
--to=buildroot@buildroot.org \
--cc=adam.duskett@amarulasolutions.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox