Re: [Buildroot] [PATCH] package/nodejs: fix additional modules installation

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Marcus, All,

On 2023-11-06 20:12 +0100, Marcus Hoffmann via buildroot spake thusly:
> Thanks Guilio, this fixes our build problem!
> 
> On 31.10.23 10:01, Giulio Benetti wrote:
> >At the moment the npm_config_nodedir is set to the build directory but
> >npm nodedir must be the one on target to find the expected files. So let's
> >set npm_config_nodedir to $(TARGET_DIR)/usr.
> >
> >Fixes:
> >https://bugs.busybox.net/show_bug.cgi?id=15826
> >
> >Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> Tested-by: Marcus Hoffmann <marcus.hoffmann@othermo.de>

Thanks for providing your tested-by tag.

However, since I changed the patch to use STAGING_DIR instead of
TARGET_DIR, I dropped your tested-by, because the new code is now too
different from what you tested.

Still, seeing a Tested-by tag on such a patch gave me enough interest
to look deeper and investigate to find the actual issue and come up with
a better fix. So, thank you!

Regards,
Yann E. MORIN.

> >---
> >  package/nodejs/nodejs.mk | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
> >index 2a8c570932..8f86413049 100644
> >--- a/package/nodejs/nodejs.mk
> >+++ b/package/nodejs/nodejs.mk
> >@@ -20,7 +20,7 @@ NODEJS_BIN_ENV = $(TARGET_CONFIGURE_OPTS) \
> >      npm_config_arch=$(NODEJS_CPU) \
> >      npm_config_target_arch=$(NODEJS_CPU) \
> >      npm_config_build_from_source=true \
> >-     npm_config_nodedir=$(BUILD_DIR)/nodejs-$(NODEJS_VERSION) \
> >+     npm_config_nodedir=$(TARGET_DIR)/usr \
> >      npm_config_prefix=$(TARGET_DIR)/usr \
> >      npm_config_cache=$(BUILD_DIR)/.npm-cache
> >
> ________________________________
> 
> othermo GmbH | Sitz der Gesellschaft: Alzenau | Amtsgericht Aschaffenburg: HRB 14783 | USt-IdNr.: DE319977978 | Geschäftsführung: Dr. Dennis Metz.
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot