Re: [Buildroot] [PATCH v2 19/24] package/python-pygame: drop package

["Yann E. MORIN" <yann.morin.1998@free.fr>]

ADam, All,

On 2023-11-09 15:51 -0700, Adam Duskett spake thusly:
> Hello Yann;
> Did you test python-pygame with setuptools against python 3.12.0?

Obviously, no. But the commit log from James was hinting that it would
work.

> I receive the following error:
> src/surface.c:2812:14: error: invalid type argument of unary ‘*’ (have ‘int’)
>  2812 |         ch = *PyUnicode_AS_UNICODE (obj);
>       |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> src/surface.c: In function ‘PySurface_Blit’:

This is useful information that should have been part of the commitlog:

    Even switching to setuptools, is not enough, as the package still
    fails to build:
        src/surface.c:2812:14: error: invalid type argument of unary ‘*’ (have ‘int’)
        blablabla...

Also, having that comment as a review of James' patch would have helped
avoid the situation.

Thanks for the feedback! :-)

Regards,
Yann E. MORIN.

> Thanks!
> 
> Adam Duskett
> 
> Senior Embedded Systems Developer
> 
> M. +1208-515-8102
> 
> [1]adam.duskett@amarulasolutions.com
> 
> __________________________________
> 
> Amarula Solutions BV
> 
> Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> 
> T. +31 (0)85 111 9170
> [2]info@amarulasolutions.com
> 
> [3]www.amarulasolutions.com
> 
> On Thu, Nov 9, 2023 at 2:52 PM Yann E. MORIN < [4]yann.morin.1998@free.fr> wrote:
> 
>   Adam, All,
> 
>   On 2023-11-05 13:25 -0700, Adam Duskett spake thusly:
>   > The python-pygame package has not recieved any update since
>   > Sun May 1 22:15:17 2016 (commit: a9ec96e545102ae5ccd4280323d35360b0a5072d)
>   > As python 3.12.0 no longer supports distutils, drop the package as the package
>   > is clearly unmaintained.
>   >
>   > If someone wants to re-introduce this package at a later date they are more
>   > than welcome to do so!
> 
>   Thet got a respite, as I applied James patch to switch to setuptools
>   instead of distutils:
> 
>       e759e927b344  package/python-pygame: switch from distutils to setuptools
> 
>   So, this patch that drops pyhon-pygame is no longer needed; I've marked
>   it rekected in patchwork.
> 
>   Thanks!
> 
>   Regards,
>   Yann E. MORIN.
> 
>   > Signed-off-by: Adam Duskett < [5]adam.duskett@amarulasolutions.com>
>   > ---
>   > v1 -> v2:
>   >  - Remove python-pygame from the DEVELOPERS file
>   >  - Don't remove python-pyxb from Config.in in this patch.
>   >
>   >  DEVELOPERS                             
>    |   1 -
>   >  package/Config.in                        |   1 -
>   >  package/python-pygame/Config.in          |  50 ----------
>   >  package/python-pygame/python-pygame.hash |   3 -
>   >  package/python-pygame/ [6]python-pygame.mk   | 111 -----------------------
>   >  5 files changed, 166 deletions(-)
>   >  delete mode 100644 package/python-pygame/Config.in
>   >  delete mode 100644 package/python-pygame/python-pygame.hash
>   >  delete mode 100644 package/python-pygame/ [7]python-pygame.mk
>   >
>   > diff --git a/DEVELOPERS b/DEVELOPERS
>   > index 3334cad77f..b890fb2586 100644
>   > --- a/DEVELOPERS
>   > +++ b/DEVELOPERS
>   > @@ -1687,7 +1687,6 @@ F:      package/libcddb/
>   >  F:   package/libmodbus/
>   >  F:   package/ltris/
>   >  F:   package/opentyrian/
>   > -F:   package/python-pygame/
>   > 
>   >  N:   Julien Corjon < [8]corjon.j@ecagroup.com>
>   >  F:   package/qt5/
>   > diff --git a/package/Config.in b/package/Config.in
>   > index 32347fe4e8..19e5035878 100644
>   > --- a/package/Config.in
>   > +++ b/package/Config.in
>   > @@ -1228,7 +1228,6 @@ menu "External python modules"
>   >       source "package/python-pydyf/Config.in"
>   >       source "package/python-pyelftools/Config.in"
>   >       source "package/python-pyftpdlib/Config.in"
>   > -     source "package/python-pygame/Config.in"
>   >       source "package/python-pygments/Config.in"
>   >       source "package/python-pyhamcrest/Config.in"
>   >       source "package/python-pyicu/Config.in"
>   > diff --git a/package/python-pygame/Config.in b/package/python-pygame/Config.in
>   > deleted file mode 100644
>   > index 57eb020742..0000000000
>   > --- a/package/python-pygame/Config.in
>   > +++ /dev/null
>   > @@ -1,50 +0,0 @@
>   > -config BR2_PACKAGE_PYTHON_PYGAME
>   > -     bool "python-pygame"
>   > -     select BR2_PACKAGE_SDL
>   > -     help
>   > -       Pygame is a cross-platfrom library designed to make it easy
>   > -       to write multimedia software, such as games, in
>   > -       Python. Pygame requires the Python language and SDL
>   > -       multimedia library.
>   > -       It can also make use of several other popular libraries.
>   > -
>   > -        [9]http://www.pygame.org/
>   > -
>   > -if BR2_PACKAGE_PYTHON_PYGAME
>   > -config BR2_PACKAGE_PYTHON_PYGAME_IMAGE
>   > -     bool "pygame.image"
>   > -     select BR2_PACKAGE_SDL_IMAGE
>   > -     select BR2_PACKAGE_SDL_IMAGE_PNG
>   > -     select BR2_PACKAGE_SDL_IMAGE_JPEG
>   > -     help
>   > -       pygame module for loading, saving and transfering images.
>   > -       Will autoselect sdl_image with png and jpeg support.
>   > -
>   > -config BR2_PACKAGE_PYTHON_PYGAME_EXAMPLES
>   > -     bool "pygame.examples"
>   > -     help
>   > -       Include examples.
>   > -       Selecting this option adds about 1.5 MB to the target file
>   > -       system.
>   > -
>   > -config BR2_PACKAGE_PYTHON_PYGAME_FONT
>   > -     bool "pygame.font"
>   > -     select BR2_PACKAGE_SDL_TTF
>   > -     help
>   > -       pygame module for loading and rendering fonts.
>   > -       Will autoselect sdl_ttf.
>   > -
>   > -config BR2_PACKAGE_PYTHON_PYGAME_MIXER
>   > -     bool "pygame.mixer"
>   > -     select BR2_PACKAGE_SDL_MIXER
>   > -     help
>   > -       pygame module for loading and playing sounds.
>   > -       Will autoselect sdl_mixer.
>   > -
>   > -config BR2_PACKAGE_PYTHON_PYGAME_SCRAP
>   > -     bool "pygame.scrap"
>   > -     depends on BR2_PACKAGE_SDL_X11
>   > -     help
>   > -       pygame module for clipboard support (X11 needed)
>   > -
>   > -endif
>   > diff --git a/package/python-pygame/python-pygame.hash b/package/python-pygame/python-pygame.hash
>   > deleted file mode 100644
>   > index c0496515e2..0000000000
>   > --- a/package/python-pygame/python-pygame.hash
>   > +++ /dev/null
>   > @@ -1,3 +0,0 @@
>   > -# Locally computed
>   > -sha256  f95a7dd68ea294d415e36e068d2f533c5a01c67773452d14a535c5c7455681fe  pygame-d61ea8eabd56.tar.gz
>   > -sha256  a190dc9c8043755d90f8b0a75fa66b9e42d4af4c980bf5ddc633f0124db3cee7  LGPL
>   > diff --git a/package/python-pygame/ [10]python-pygame.mk b/package/python-pygame/ [11]python-pygame.mk
>   > deleted file mode 100644
>   > index 600dd9e743..0000000000
>   > --- a/package/python-pygame/ [12]python-pygame.mk
>   > +++ /dev/null
>   > @@ -1,111 +0,0 @@
>   > -################################################################################
>   > -#
>   > -# python-pygame
>   > -#
>   > -################################################################################
>   > -
>   > -# stable 1.9.1 release requires V4L which has been wiped out of recent Linux
>   > -# kernels, so use latest mercurial revision until next stable release is out.
>   > -PYTHON_PYGAME_VERSION = d61ea8eabd56
>   > -PYTHON_PYGAME_SOURCE = pygame-$(PYTHON_PYGAME_VERSION).tar.gz
>   > -PYTHON_PYGAME_SITE = [13]https://bitbucket.org/pygame/pygame
>   > -PYTHON_PYGAME_SITE_METHOD = hg
>   > -PYTHON_PYGAME_SETUP_TYPE = distutils
>   > -PYTHON_PYGAME_LICENSE = LGPL-2.1+
>   > -PYTHON_PYGAME_LICENSE_FILES = LGPL
>   > -
>   > -ifeq ($(BR2_PACKAGE_PYTHON_PYGAME_IMAGE),y)
>   > -PYTHON_PYGAME_OPT_DEPENDS += sdl_image
>   > -endif
>   > -
>   > -ifeq ($(BR2_PACKAGE_PYTHON_PYGAME_FONT),y)
>   > -PYTHON_PYGAME_OPT_DEPENDS += sdl_ttf
>   > -endif
>   > -
>   > -ifeq ($(BR2_PACKAGE_PYTHON_PYGAME_MIXER),y)
>   > -PYTHON_PYGAME_OPT_DEPENDS += sdl_mixer
>   > -endif
>   > -
>   > -PYTHON_PYGAME_DEPENDENCIES = sdl $(PYTHON_PYGAME_OPT_DEPENDS)
>   > -
>   > -ifneq ($(BR2_PACKAGE_PYTHON_PYGAME_IMAGE),y)
>   > -define PYTHON_PYGAME_UNCONFIGURE_IMAGE
>   > -     $(SED) 's/^imageext/#imageext/' $(@D)/Setup
>   > -endef
>   > -endif
>   > -
>   > -ifneq ($(BR2_PACKAGE_PYTHON_PYGAME_FONT),y)
>   > -define PYTHON_PYGAME_UNCONFIGURE_FONT
>   > -     $(SED) 's/^font/#font/' $(@D)/Setup
>   > -endef
>   > -endif
>   > -
>   > -ifneq ($(BR2_PACKAGE_PYTHON_PYGAME_MIXER),y)
>   > -define PYTHON_PYGAME_UNCONFIGURE_MIXER
>   > -     $(SED) 's/^mixer/#mixer/g' $(@D)/Setup
>   > -endef
>   > -endif
>   > -
>   > -# Both require numpy or numeric python module
>   > -define PYTHON_PYGAME_UNCONFIGURE_SNDARRAY
>   > -     $(SED) 's/^_numericsndarray/#_numericsndarray/' $(@D)/Setup
>   > -endef
>   > -
>   > -define PYTHON_PYGAME_UNCONFIGURE_SURFARRAY
>   > -     $(SED) 's/^_numericsurfarray/#_numericsurfarray/' $(@D)/Setup
>   > -endef
>   > -
>   > -# Requires smpeg
>   > -define PYTHON_PYGAME_UNCONFIGURE_MOVIE
>   > -     $(SED) 's/^movie/#movie/' $(@D)/Setup
>   > -endef
>   > -
>   > -ifneq ($(BR2_PACKAGE_PYTHON_PYGAME_SCRAP),y)
>   > -define PYTHON_PYGAME_UNCONFIGURE_SCRAP
>   > -     $(SED) 's/^scrap/#scrap/' $(@D)/Setup
>   > -endef
>   > -endif
>   > -
>   > -define PYTHON_PYGAME_UNCONFIGURE_FREETYPE
>   > -     $(SED) 's/^_freetype/#_freetype/' $(@D)/Setup
>   > -endef
>   > -
>   > -PYTHON_PYGAME_SDL_FLAGS = `$(STAGING_DIR)/usr/bin/sdl-config --cflags`
>   > -PYTHON_PYGAME_SDL_FLAGS += `$(STAGING_DIR)/usr/bin/sdl-config --libs`
>   > -
>   > -# Pygame needs a Setup file where options should be commented out if
>   > -# dependencies are not available
>   > -define PYTHON_PYGAME_CONFIGURE_CMDS
>   > -     cp -f $(@D)/Setup.in $(@D)/Setup
>   > -     $(SED) "s~^SDL = ~SDL = $(PYTHON_PYGAME_SDL_FLAGS) \n#~" $(@D)/Setup
>   > -     $(SED) 's/^pypm/#pypm/' $(@D)/Setup
>   > -     $(PYTHON_PYGAME_UNCONFIGURE_IMAGE)
>   > -     $(PYTHON_PYGAME_UNCONFIGURE_FONT)
>   > -     $(PYTHON_PYGAME_UNCONFIGURE_MIXER)
>   > -     $(PYTHON_PYGAME_UNCONFIGURE_SNDARRAY)
>   > -     $(PYTHON_PYGAME_UNCONFIGURE_SURFARRAY)
>   > -     $(PYTHON_PYGAME_UNCONFIGURE_MOVIE)
>   > -     $(PYTHON_PYGAME_UNCONFIGURE_SCRAP)
>   > -     $(PYTHON_PYGAME_UNCONFIGURE_FREETYPE)
>   > -endef
>   > -
>   > -define PYTHON_PYGAME_REMOVE_DOC
>   > -     rm -rf $(TARGET_DIR)/usr/lib/python*/site-packages/pygame/docs
>   > -endef
>   > -
>   > -PYTHON_PYGAME_POST_INSTALL_TARGET_HOOKS += PYTHON_PYGAME_REMOVE_DOC
>   > -
>   > -define PYTHON_PYGAME_REMOVE_TESTS
>   > -     rm -rf $(TARGET_DIR)/usr/lib/python*/site-packages/pygame/tests
>   > -endef
>   > -
>   > -PYTHON_PYGAME_POST_INSTALL_TARGET_HOOKS += PYTHON_PYGAME_REMOVE_TESTS
>   > -
>   > -ifneq ($(BR2_PACKAGE_PYTHON_PYGAME_EXAMPLES),y)
>   > -define PYTHON_PYGAME_REMOVE_EXAMPLES
>   > -     rm -rf $(TARGET_DIR)/usr/lib/python$(PYTHON3_VERSION_MAJOR)/site-packages/pygame/examples
>   > -endef
>   > -PYTHON_PYGAME_POST_INSTALL_TARGET_HOOKS += PYTHON_PYGAME_REMOVE_EXAMPLES
>   > -endif
>   > -
>   > -$(eval $(python-package))
>   > --
>   > 2.41.0
>   >
>   > _______________________________________________
>   > buildroot mailing list
>   > [14]buildroot@buildroot.org
>   > [15]https://lists.buildroot.org/mailman/listinfo/buildroot
> 
>   --
>   .-----------------.--------------------.------------------.--------------------.
>   |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
>   | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___           
>      |
>   | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
>   | [16]http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
>   '------------------------------^-------^------------------^--------------------'
> 
> Links:
> 1. mailto:adam.duskett@amarulasolutions.com
> 2. mailto:info@amarulasolutions.com
> 3. http://www.amarulasolutions.com/
> 4. mailto:yann.morin.1998@free.fr
> 5. mailto:adam.duskett@amarulasolutions.com
> 6. http://python-pygame.mk
> 7. http://python-pygame.mk
> 8. mailto:corjon.j@ecagroup.com
> 9. http://www.pygame.org/
> 10. http://python-pygame.mk
> 11. http://python-pygame.mk
> 12. http://python-pygame.mk
> 13. https://bitbucket.org/pygame/pygame
> 14. mailto:buildroot@buildroot.org
> 15. https://lists.buildroot.org/mailman/listinfo/buildroot
> 16. http://ymorin.is-a-geek.org/

> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot


-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot