Re: [Buildroot] [PATCH 1/1] board/raspberrypi: fix autoprobing of bluetooth driver

[Peter Seiderer <ps.report@gmx.net>]

Hello *,

On Mon, 20 Nov 2023 22:41:50 +0100, Gaël PORTAY <gael.portay@rtone.fr> wrote:

> The commit 689b9ac439 (package/rpi-firmware: rework boot/config file
> handling) has split in two the property:
> 
> 	dtoverlay=miniuart-bt,krnbt=on
> 
> Into:
> 
> 	dtoverlay=miniuart-bt
> 	dtoverlay=krnbt=on
> 
> The initial property contained the dtbo file miniuart-bt[1] and its
> parameter krnbt=on[2][3].
> 
> The first syntax is correct while the second is not. The krnbt=on is not
> a dtoverlay[4] but a dtparam[5]. Therefore the property dtparam must be
> used instead.
> 
> This fixes:
> 
> 	# cat /sys/firmware/devicetree/base/chosen/user-warnings
> 	Failed to load overlay 'krnbt=on'
> 
> [1]: https://github.com/raspberrypi/linux/blob/rpi-5.10.y/arch/arm/boot/dts/overlays/miniuart-bt-overlay.dts
> [2]: https://github.com/raspberrypi/linux/blob/rpi-5.10.y/arch/arm/boot/dts/overlays/miniuart-bt-overlay.dts#L91
> [3]: https://github.com/raspberrypi/linux/blob/rpi-5.10.y/arch/arm/boot/dts/overlays/README#L213-L215
> [4]: https://www.raspberrypi.com/documentation/computers/config_txt.html#dtoverlay
> [5]: https://www.raspberrypi.com/documentation/computers/config_txt.html#dtparam
> 
> Signed-off-by: Gaël PORTAY <gael.portay@rtone.fr>
> ---
>  board/raspberrypi/config_0w.txt      | 2 +-
>  board/raspberrypi/config_3.txt       | 2 +-
>  board/raspberrypi/config_3_64bit.txt | 2 +-
>  board/raspberrypi/config_4.txt       | 2 +-
>  board/raspberrypi/config_4_64bit.txt | 2 +-
>  board/raspberrypi/config_zero2w.txt  | 2 +-
>  6 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/board/raspberrypi/config_0w.txt b/board/raspberrypi/config_0w.txt
> index 195bad449e..bc59d5fad2 100644
> --- a/board/raspberrypi/config_0w.txt
> +++ b/board/raspberrypi/config_0w.txt
> @@ -26,4 +26,4 @@ gpu_mem_1024=100
>  dtoverlay=miniuart-bt
> 
>  # enable autoprobing of Bluetooth driver without need of hciattach/btattach
> -dtoverlay=krnbt=on
> +dtparam=krnbt=on
> diff --git a/board/raspberrypi/config_3.txt b/board/raspberrypi/config_3.txt
> index 195bad449e..bc59d5fad2 100644
> --- a/board/raspberrypi/config_3.txt
> +++ b/board/raspberrypi/config_3.txt
> @@ -26,4 +26,4 @@ gpu_mem_1024=100
>  dtoverlay=miniuart-bt
> 
>  # enable autoprobing of Bluetooth driver without need of hciattach/btattach
> -dtoverlay=krnbt=on
> +dtparam=krnbt=on
> diff --git a/board/raspberrypi/config_3_64bit.txt b/board/raspberrypi/config_3_64bit.txt
> index 34412fa9e8..6672871125 100644
> --- a/board/raspberrypi/config_3_64bit.txt
> +++ b/board/raspberrypi/config_3_64bit.txt
> @@ -26,7 +26,7 @@ gpu_mem_1024=100
>  dtoverlay=miniuart-bt
> 
>  # enable autoprobing of Bluetooth driver without need of hciattach/btattach
> -dtoverlay=krnbt=on
> +dtparam=krnbt=on
> 
>  # enable 64bits support
>  arm_64bit=1
> diff --git a/board/raspberrypi/config_4.txt b/board/raspberrypi/config_4.txt
> index ea02d3f071..74a7b270cd 100644
> --- a/board/raspberrypi/config_4.txt
> +++ b/board/raspberrypi/config_4.txt
> @@ -26,4 +26,4 @@ gpu_mem_1024=100
>  dtoverlay=miniuart-bt
> 
>  # enable autoprobing of Bluetooth driver without need of hciattach/btattach
> -dtoverlay=krnbt=on
> +dtparam=krnbt=on
> diff --git a/board/raspberrypi/config_4_64bit.txt b/board/raspberrypi/config_4_64bit.txt
> index 41c7e97e99..2a9814274f 100644
> --- a/board/raspberrypi/config_4_64bit.txt
> +++ b/board/raspberrypi/config_4_64bit.txt
> @@ -26,7 +26,7 @@ gpu_mem_1024=100
>  dtoverlay=miniuart-bt
> 
>  # enable autoprobing of Bluetooth driver without need of hciattach/btattach
> -dtoverlay=krnbt=on
> +dtparam=krnbt=on
> 
>  dtoverlay=vc4-kms-v3d-pi4
>  dtoverlay=imx219
> diff --git a/board/raspberrypi/config_zero2w.txt b/board/raspberrypi/config_zero2w.txt
> index 9e6b7f5ccf..55095f64a7 100644
> --- a/board/raspberrypi/config_zero2w.txt
> +++ b/board/raspberrypi/config_zero2w.txt
> @@ -26,4 +26,4 @@ gpu_mem_1024=100
>  dtoverlay=miniuart-bt
> 
>  # enable autoprobing of Bluetooth driver without need of hciattach/btattach
> -dtoverlay=krnbt=on
> +dtparam=krnbt=on
> --
> 2.42.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

...alternative patch (removing the failing line) already suggested, see [6] for
details and reasoning...

Regards,
Peter

[6] https://patchwork.ozlabs.org/project/buildroot/patch/20230808180959.28091-2-ps.report@gmx.net/

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot