From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Asaf Kahlon <asafka7@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/3] package/python-pydantic-core: new package
Date: Sun, 26 Nov 2023 17:39:55 +0100 [thread overview]
Message-ID: <20231126163955.GX3177259@scaer> (raw)
In-Reply-To: <CADvTj4qHe+Puev4JLopaBbH-Kq0+NAR_GH0G43JkcGy125tqXQ@mail.gmail.com>
James, All,
On 2023-11-26 09:19 -0700, James Hilliard spake thusly:
> On Sun, Nov 26, 2023 at 4:27 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > > On Sat, Nov 25, 2023 at 8:36 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
[--SNIP--]
> > > There's no conflict since pydantic-core is a new package with no reverse
> > > dependencies.
> > It is not just about reverse dependencies. Assuming we just apply the
> > pydantic-core new package, and keep the old pydantic (e.g we have to
> > revert the bump later for various reasons), what happens at build time
> > or at runtime, if the user enables pydantic-core and pydantic (the old)?
> So pydantic-core is just a new dependency for pydantic to handle core
> validation logic. If pydantic-core is used with old pydantic there shouldn't
> be any build/runtime issues as they would not conflict in any way.
>
> > If that makes pydantic-old fail to build or run, that is what we care
> > about.
> Why would it make pydantic-old fail? The pydantic-core package uses a
> different module namespace which is typically how python packages
> prevent import conflicts in general.
>
> To import from pydantic-core you import like:
> from pydantic_core import SchemaValidator, ValidationError
>
> To import from pydantic you import like:
> from pydantic import BaseModel
>
> New pydantic simply internally imports from pydantic_core but old
> pydantic does not and will function the same whether or not we have
> pydantic_core installed.
So, pydantic-core does not provide a subset of the modules previously in
pydantic, so there will not be a conflict.
Thanks for the explanations. :-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-11-26 16:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-25 8:10 [Buildroot] [PATCH 1/3] package/python-annotated-types: new package James Hilliard
2023-11-25 8:10 ` [Buildroot] [PATCH 2/3] package/python-pydantic-core: " James Hilliard
2023-11-25 15:36 ` Yann E. MORIN
2023-11-26 0:11 ` James Hilliard
2023-11-26 11:27 ` Yann E. MORIN
2023-11-26 16:19 ` James Hilliard
2023-11-26 16:39 ` Yann E. MORIN [this message]
2023-11-26 16:46 ` James Hilliard
2023-11-26 17:12 ` Yann E. MORIN
2023-11-25 8:10 ` [Buildroot] [PATCH 3/3] package/python-pydantic: bump to version 2.5.2 James Hilliard
2023-11-26 17:12 ` Yann E. MORIN
2023-11-26 17:11 ` [Buildroot] [PATCH 1/3] package/python-annotated-types: new package Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231126163955.GX3177259@scaer \
--to=yann.morin.1998@free.fr \
--cc=asafka7@gmail.com \
--cc=buildroot@buildroot.org \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox